Opened 17 months ago

Closed 17 months ago

Last modified 14 months ago

#6788 closed change (fixed)

Integrate stylelint-config-eyeo into adblockplusui

Reported by: greiner Assignee: greiner
Priority: P3 Milestone:
Module: User-Interface Keywords:
Cc: Blocked By:
Blocking: #6892 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://gitlab.com/eyeo/adblockplus/adblockplusui/merge_requests/58

Description (last modified by greiner)

Background

See https://gitlab.com/eyeo/adblockplus/adblockplusui/issues/79

What to change

See https://gitlab.com/eyeo/adblockplus/adblockplusui/issues/79

Hints for testers

Styles should remain unchanged in all affected UI pages:

  • Bubble UI
  • Desktop options page
  • First-run page
  • Issue reporter

Change History (6)

comment:1 Changed 17 months ago by greiner

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 17 months ago by greiner

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:3 Changed 16 months ago by greiner

  • Blocking 6892 added

comment:4 Changed 16 months ago by greiner

  • Description modified (diff)

Added hints for testers.

comment:5 Changed 15 months ago by abpbot

A commit referencing this issue has landed:
Issue 6788 - Integrated stylelint-config-eyeo

comment:6 Changed 14 months ago by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Done. Styles still look fine.

ABP 3.3.2.2175
Firefox 62 / 51 / Windows 10
Chrome 69 / 49 / Windows 10
Opera 56 / 36 / Windows 10

Note: See TracTickets for help on using tickets.