Opened 16 months ago

Closed 16 months ago

Last modified 5 weeks ago

#6789 closed change (fixed)

Remove block-closing-brace-space-after stylelint rule

Reported by: greiner Assignee: ire
Priority: Unknown Milestone:
Module: Automation Keywords:
Cc: ire, juliandoucette, agiammarchi Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29831575/

Description

Background

stylelint-config-eyeo includes the rule "block-closing-brace-space-after". Since we now want to integrate stylelint into adblockplusui (see #6788) we've noticed that this rule throws an error in various places.

e.g.

.content h1 { font-size: 1.8em; }

After reading up on it in the official documentation, checking comments in the review that introduced it and checking back with the Websites team at #eyeo-websites, it is still unclear what the purpose of this rule is which is why we should remove it.

What to change

Remove "block-closing-brace-space-after" rule from stylelint-config-eyeo.

Change History (5)

comment:1 Changed 16 months ago by ire

  • Owner set to ire
  • Ready set

Thanks greiner! I think you're right, this rule shouldn't be there, not sure why I added it in the first place :/

comment:2 Changed 16 months ago by ire

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed 16 months ago by abpbot

A commit referencing this issue has landed:
Issue 6789 - Remove block-closing-brace-space-after stylelint rule

comment:4 Changed 16 months ago by ire

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:5 Changed 2 months ago by victoriaa1

spam

Last edited 5 weeks ago by kzar (previous) (diff)
Note: See TracTickets for help on using tickets.