Opened on 07/12/2018 at 11:54:03 AM

Closed on 07/21/2018 at 02:34:05 PM

Last modified on 10/08/2019 at 06:05:17 PM

#6789 closed change (fixed)

Remove block-closing-brace-space-after stylelint rule

Reported by: greiner Assignee: ire
Priority: Unknown Milestone:
Module: Automation Keywords:
Cc: ire, juliandoucette, agiammarchi Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):



stylelint-config-eyeo includes the rule "block-closing-brace-space-after". Since we now want to integrate stylelint into adblockplusui (see #6788) we've noticed that this rule throws an error in various places.


.content h1 { font-size: 1.8em; }

After reading up on it in the official documentation, checking comments in the review that introduced it and checking back with the Websites team at #eyeo-websites, it is still unclear what the purpose of this rule is which is why we should remove it.

What to change

Remove "block-closing-brace-space-after" rule from stylelint-config-eyeo.

Attachments (0)

Change History (5)

comment:1 Changed on 07/16/2018 at 06:05:40 PM by ire

  • Owner set to ire
  • Ready set

Thanks greiner! I think you're right, this rule shouldn't be there, not sure why I added it in the first place :/

comment:2 Changed on 07/16/2018 at 06:10:28 PM by ire

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed on 07/21/2018 at 09:41:11 AM by abpbot

A commit referencing this issue has landed:
Issue 6789 - Remove block-closing-brace-space-after stylelint rule

comment:4 Changed on 07/21/2018 at 02:34:05 PM by ire

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:5 Changed on 09/13/2019 at 06:34:41 AM by victoriaa1


Last edited on 10/08/2019 at 06:05:17 PM by kzar

Add Comment

Modify Ticket

Change Properties
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from ire.
Note: See TracTickets for help on using tickets.