Opened 2 years ago

Closed 2 years ago

Last modified 10 months ago

#6789 closed change (fixed)

Remove block-closing-brace-space-after stylelint rule

Reported by: greiner Assignee: ire
Priority: Unknown Milestone:
Module: Automation Keywords:
Cc: ire, juliandoucette, agiammarchi Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29831575/

Description

Background

stylelint-config-eyeo includes the rule "block-closing-brace-space-after". Since we now want to integrate stylelint into adblockplusui (see #6788) we've noticed that this rule throws an error in various places.

e.g.

.content h1 { font-size: 1.8em; }

After reading up on it in the official documentation, checking comments in the review that introduced it and checking back with the Websites team at #eyeo-websites, it is still unclear what the purpose of this rule is which is why we should remove it.

What to change

Remove "block-closing-brace-space-after" rule from stylelint-config-eyeo.

Change History (5)

comment:1 Changed 2 years ago by ire

  • Owner set to ire
  • Ready set

Thanks greiner! I think you're right, this rule shouldn't be there, not sure why I added it in the first place :/

comment:2 Changed 2 years ago by ire

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed 2 years ago by abpbot

A commit referencing this issue has landed:
Issue 6789 - Remove block-closing-brace-space-after stylelint rule

comment:4 Changed 2 years ago by ire

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:5 Changed 11 months ago by victoriaa1

This method appears to be very tough, there's a very easy way. Visit google edubirdy and read it many professional essay on my website. You can find wide range of new tips for code learning.

Version 0, edited 11 months ago by victoriaa1 (next)
Note: See TracTickets for help on using tickets.