#6799 closed defect (fixed)

Hebrew subscription is not installed for Hebrew locale

Reported by: asmirnov Assignee:
Priority: P3 Milestone:
Module: Libadblockplus-Android Keywords:
Cc: Blocked By:
Blocking: Platform: Android
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29835555/
https://codereview.adblockplus.org/29842555/

Description

Environment

We pass default android locale (modified) to libadblockplus and it passes it to core to choose subscriptions on the very first launch.
https://github.com/adblockplus/libadblockplus-android/blob/master/adblock-android/src/org/adblockplus/libadblockplus/android/AdblockEngine.java#L84

Hebrew subscriptions is expected to be installed for android device if Hebrew is set as Default locale but regular easylist subscription is sinstalled instead.

How to reproduce

  1. Set Hebrew as default android device locale.
  2. Run AdblockWebView demo app
  3. Navigate to any URL
  4. Make sure you can see regular easylist subscription URL is used (android logcat).

...

Observed behaviour

regular easylist subscription URL is used (android logcat)

Expected behaviour

Hebrew easylist subscription URL is used (android logcat).

Change History (11)

comment:2 Changed 16 months ago by asmirnov

It's expected to have he as country code: in our subscriptions configuration:
https://github.com/adblockplus/adblockpluscore/blob/master/chrome/content/ui/subscriptions.xml#L77

Last edited 16 months ago by asmirnov (previous) (diff)

comment:3 Changed 16 months ago by asmirnov

comment:4 Changed 16 months ago by asmirnov

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:6 Changed 16 months ago by abpbot

comment:7 Changed 16 months ago by asmirnov

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:8 Changed 16 months ago by asmirnov

  • Resolution fixed deleted
  • Status changed from closed to reopened

comment:9 Changed 16 months ago by asmirnov

  • Review URL(s) modified (diff)

comment:10 Changed 16 months ago by abpbot

comment:11 Changed 16 months ago by asmirnov

  • Resolution set to fixed
  • Status changed from reopened to closed
Note: See TracTickets for help on using tickets.