Opened 17 months ago

Closed 17 months ago

Last modified 16 months ago

#6802 closed change (fixed)

Update adblockplusui dependency to 3b97a00a1189

Reported by: greiner Assignee:
Priority: P1 Milestone: Adblock-Plus-3.3-for-Chrome-Opera-Firefox
Module: Platform Keywords:
Cc: sebastian, kzar, wspee, hfiguiere, mjethani, saroyanm, Ross, rscott Blocked By: #6784
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29840555/

Description (last modified by kzar)

Background

In #6784 we are going to introduce an anti-circumvention filter list for which we have created a basic UI to go along with it. Therefore we should update the adblockplusui dependency to include that UI in that same release as soon as we got the translations for its strings.

What to change

Update the adblockplusui dependency to hg:3b97a00a1189 git:e4c4803.


Hints for testers

  • Ensure that the "ABP Anti-Circumvention Filter List" is added into the "ANTI-CIRCUMVENTION" section of the general tab of the options page.
  • If "ABP Anti-Circumvention Filter List" is checked, the subscription list should have the "ABP Filters" list (Advanced tab)
  • Removing the "ABP Filters" entry in the subscription list (Advanced tab) should make "ABP Anti-Circumvention Filter List" unchecked.

For more details about how it should behave see the specification in GitLab.

Change History (14)

comment:1 Changed 17 months ago by hfiguiere

  • Cc hfiguiere added

comment:2 Changed 17 months ago by mjethani

  • Cc mjethani added

comment:3 Changed 17 months ago by saroyanm

  • Cc saroyanm added
  • Description modified (diff)
  • Summary changed from Update adblockplusui dependency to TBA to Update adblockplusui dependency to 3b97a00a1189

Updated the ticket with hashes, I think this ticket can be marked as ready.

comment:4 Changed 17 months ago by saroyanm

  • Description modified (diff)

Removed missing information section

comment:5 follow-up: Changed 17 months ago by kzar

  • Cc Ross rscott added
  • Description modified (diff)
  • Priority changed from Unknown to P1

Please can you add a hints for testers section, which explains how the UI relating to the circumvention filter should function with this change?

comment:6 Changed 17 months ago by saroyanm

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:7 in reply to: ↑ 5 Changed 17 months ago by saroyanm

Replying to kzar:

Please can you add a hints for testers section, which explains how the UI relating to the circumvention filter should function with this change?

Good point.

@greiner and/or @hfiguiere probably knows better(if there are worth notting details for testers), as they were working on the implementation AFAIK, if they don't take that over, I'll check the details and add the section accordingly.

comment:8 Changed 17 months ago by saroyanm

  • Description modified (diff)

Added"Hints for testers".

comment:9 Changed 17 months ago by kzar

  • Description modified (diff)
  • Ready set

comment:10 Changed 17 months ago by abpbot

A commit referencing this issue has landed:
Issue 6802 - Update adblockplusui dependency to 3b97a00a1189

comment:11 Changed 17 months ago by saroyanm

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:12 Changed 17 months ago by hfiguiere

  • Description modified (diff)

comment:13 Changed 17 months ago by kzar

  • Description modified (diff)

Thanks for adding those details Hubert.

comment:14 Changed 16 months ago by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Done. Circumvention list UI elements behave as described.

ABP 3.2.0.2103
Chrome 68 / 55 / 49 / Windows 10
Firefox 61 / 55 / 51 / Windows 10

Note: See TracTickets for help on using tickets.