Opened 2 years ago

Last modified 2 years ago

#6808 closed defect

Element hiding filter still applied on domain whitelisted by $elemhide — at Version 4

Reported by: arthur Assignee: kzar
Priority: P2 Milestone: Adblock-Plus-3.3-for-Chrome-Opera-Firefox
Module: Platform Keywords:
Cc: sebastian, kzar, scuturic, mbollien, rscott, Ross, BrentM, weissmar Blocked By:
Blocking: Platform: Chrome
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29838555/

Description (last modified by kzar)

Environment

Windows 10 Pro
Chrome 68.0.3440.75 (Official Build) (64-bit)
ABP 3.2.0.2093, also happening with 3.2
EasyList
AA

How to reproduce

  1. Open the ABP tab in the dev tools panel
  2. Go to https://www.olx.pl/motoryzacja/samochody/
  3. Change the drop down item on the left to show only "ELEMHIDE" items

Observed behaviour

You see @@||olx.pl^$elemhide from AA being applied but also ##iframe[id^="google_ads_frame"] from EasyList

Expected behaviour

Element hiding should be whitelisted completely.

Notes

  • There is no domain for the document for that hiding filter. Also, if you add olx.pl#@#iframe[id^="google_ads_frame"], it works like on every 2nd refresh.
  • This is has been a problem since commit 7781a9fc138e.

Change History (4)

comment:1 Changed 2 years ago by arthur

  • Description modified (diff)

comment:2 Changed 2 years ago by arthur

  • Description modified (diff)

comment:3 Changed 2 years ago by kzar

  • Owner set to kzar
  • Priority changed from Unknown to P2

I can reproduce, but this definitely isn't a regression since the last release. Investigating now.

comment:4 Changed 2 years ago by kzar

  • Description modified (diff)
Note: See TracTickets for help on using tickets.