Changes between Initial Version and Version 2 of Ticket #6809


Ignore:
Timestamp:
07/26/2018 12:23:59 PM (21 months ago)
Author:
mjethani
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #6809

    • Property Cc kzar hfiguiere added
    • Property Component changed from Unknown to Core
    • Property Priority changed from Unknown to P2
    • Property Keywords circumvention added
    • Property Ready set
  • Ticket #6809 – Description

    initial v2  
    11=== Background === 
    2 Replace this text with your reasoning that lead to wanting the change. 
     2The problem is described in #6804. 
     3 
     4Until this improvement is made to element hiding emulation, we should use a snippet to hide an ad before the user sees it. 
    35 
    46=== What to change === 
    5 Replace this text with the detailed description of what exactly shall be changed/added and where. 
     7Implement a snippet called `hide-if-contains` with the following signature: 
     8 
     9{{{ 
     10function hideIfContains(search, selector = "*") 
     11}}} 
     12 
     13On any DOM modification, the snippet should use `document.querySelectorAll(selector)` to look up all elements that match the given CSS selector, then look for `search` in each element's text content and hide the element if the string is found. 
  • Ticket #6809 – Review URL(s)

    initial v2  
     1https://codereview.adblockplus.org/29836573/