Changes between Version 4 and Version 13 of Ticket #6821


Ignore:
Timestamp:
07/31/2018 03:41:53 PM (2 years ago)
Author:
kzar
Comment:

Replying to Ross:

The 3.2.0.2097 devbuild appears to work in Chrome 50 after a quick check. The above console errors are not thrown and first run page, functionality appear to be working okay too.

Thanks for confirming that, I've updated the description.

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #6821

    • Property Cc greiner added
  • Ticket #6821 – Description

    v4 v13  
    44 
    55Works fine in Chrome 55+. 
    6 Not able to check in Chrome 50-54. 
     6Smoke tested with Chrome 50. 
     7Not able to check in Chrome 51-54. 
    78 
    89Is fine in Firefox's min supported version (51) 
     
    3637=== Expected behaviour === 
    3738The extension to work as expected in Chrome 49. 
     39 
     40=== Notes === 
     41- This is a regression since the previous release. 
     42- This seems to only be a problem with Chrome <50. 
     43- The problem seems to be caused by the use of the Unicode "u" regular expression flag, which [https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/RegExp/unicode according to MDN wasn't supported until Chrome 50]. The following commits introduced the flag into our codebase: 
     44  - [https://hg.adblockplus.org/adblockpluscore/rev/5f851931ffea#l1.83 5f851931ffea] `adblockpluscore/lib/snippets.js` 
     45  - [https://hg.adblockplus.org/adblockpluscore/rev/926b9df46ce6#l1.60 926b9df46ce6] `adblockpluscore/lib/common.js` 
     46  - [https://hg.adblockplus.org/adblockpluscore/rev/7052e279497a#l2.42 7052e279497a] `adblockpluscore/test/browser/elemHideEmulation.js`