Opened 2 years ago

Last modified 2 years ago

#6821 closed defect

Extension broken on Chrome 49 — at Version 4

Reported by: Ross Assignee:
Priority: P1 Milestone:
Module: Platform Keywords:
Cc: sebastian, kzar, greiner, hfiguiere, mjethani Blocked By:
Blocking: Platform: Chrome
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description (last modified by kzar)

Environment

ABP 3.2.0.2097
Chrome 49

Works fine in Chrome 55+.
Not able to check in Chrome 50-54.

Is fine in Firefox's min supported version (51)

How to reproduce

  1. Install extension.
  2. Attempt to open options page.

Observed behaviour

The first run page does not open. The options page cannot be opened from the popup UI. Ad blocking does not work.

Some errors from the background console:

    Uncaught SyntaxError: Invalid regular expression flags    adblockplus.js:6274

some errors from the popup console:

    extensions::uncaught_exception_handler:8 Error in event handler for (unknown): TypeError: Cannot read property 'locale' of undefined
    at browser.runtime.sendMessage (chrome-extension://ldcecbkkoecffmfljeihcmifjjdoepkn/i18n.js:31:47)handler @ extensions::uncaught_exception_handler:8

    extensions::uncaught_exception_handler:8 Error in event handler for (unknown): TypeError: Cannot read property 'toLocaleString' of undefined
    at browser.runtime.sendMessage.blockedPage (chrome-extension://ldcecbkkoecffmfljeihcmifjjdoepkn/popup.js:177:41)handler @ extensions::uncaught_exception_handler:8

    extensions::uncaught_exception_handler:8 Error in event handler for (unknown): TypeError: Cannot read property 'toLocaleString' of undefined
    at blockedTotal (chrome-extension://ldcecbkkoecffmfljeihcmifjjdoepkn/popup.js:184:42)

Expected behaviour

The extension to work as expected in Chrome 49.

Change History (4)

comment:1 Changed 2 years ago by kzar

Uncaught SyntaxError: Invalid regular expression flags adblockplus.js:6274

It seems that Chrome 49 doesn't support the "u" flag for regular expressions, this exception in particular is caused by 5f851931ffea in adblockpluscore/lib/snippets.js, but I can see 926b9df46ce6 added one to adblockpluscore/lib/common.js, and 7052e279497a added one to adblockpluscore/test/browser/elemHideEmulation.js.

comment:3 Changed 2 years ago by kzar

I can't see any obvious cause of those popup console exceptions, I suspect they might just be a side-effect of the exceptions thrown in the background console. Especially the ones that relate to the responses to messages sent to the background being undefined.

comment:4 Changed 2 years ago by kzar

  • Description modified (diff)
  • Priority changed from Unknown to P1
  • Ready set
Note: See TracTickets for help on using tickets.