Opened 3 months ago

Closed 3 months ago

Last modified 2 months ago

#6823 closed change (fixed)

Remove unnecessary usage of the /u flag in regular expressions

Reported by: mjethani Assignee: mjethani
Priority: P1 Milestone:
Module: Core Keywords:
Cc: kzar Blocked By:
Blocking: #6821 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29843588/

Description (last modified by mjethani)

Background

See #6821 for the background.

In a couple of places we are using the /u flag in regular expressions where it is not really needed, as it does not affect \s (whitespace matching). Since Chrome 49 does not support the /u flag, we should remove it.

What to change

In lib/snippets.js and lib/common.js remove the unnecessary usage of the /u flag in the two places where it is being used.

Hints for testers

Same as #6781 and #6619, but focus on whitespace in the snippet filter and the CSS selector respectively.

Change History (8)

comment:1 Changed 3 months ago by mjethani

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 3 months ago by mjethani

  • Description modified (diff)

comment:3 Changed 3 months ago by mjethani

  • Description modified (diff)

comment:4 Changed 3 months ago by abpbot

A commit referencing this issue has landed:
Issue 6823 - Remove unnecessary usage of /u flag

comment:5 Changed 3 months ago by mjethani

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:6 Changed 3 months ago by mjethani

  • Description modified (diff)
  • Summary changed from Remove unnecessary usage of the u flag in regular expressions to Remove unnecessary usage of the /u flag in regular expressions

comment:7 Changed 3 months ago by abpbot

A commit referencing this issue has landed:
Issue 6823 - Remove unnecessary usage of /u flag

comment:8 Changed 2 months ago by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Done. Extension works in Chrome 49 again. The snippet and selector changes also work as expected.

ABP 3.2.0.2103
Chrome 68 / 55 / 49 / Windows 10
Firefox 61 / 55 / 51 / Windows 10

Note: See TracTickets for help on using tickets.