Changes between Version 12 and Version 14 of Ticket #6825


Ignore:
Timestamp:
08/02/2018 09:16:19 AM (15 months ago)
Author:
mjethani
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #6825

    • Property Summary changed from Update adblockpluscore dependency to hg:c7c3b5e643f4 to Update adblockpluscore dependency to hg:d9196c0de5f2
  • Ticket #6825 – Description

    v12 v14  
    55 
    66=== What to change === 
    7 Update the `adblockpluscore` dependency in the `dependencies` file to `hg:c7c3b5e643f4 git:baafb26`. 
     7Update the `adblockpluscore` dependency in the `dependencies` file to `hg:d9196c0de5f2 git:16febf9`. 
    88 
    99Unfortunately, as well as the necessary change 
     
    1313the following unrelated changes will be included: 
    1414 
    15 - #6538, #6781 - Minimize access to ElemHideBase's selector property 
    1615- #6809 - Implement hide-if-contains snippet 
    17 - #6814 - Avoid redundant calls to domains getter 
    1816 
    1917=== Hints for testers === 
    20 - Ensure that the extension has begun working on Chrome 49 again. Smoke test all functionality, checking for exceptions in the console for the background page, options page and popup. Also make sure to test [https://adblockplus.org/development-builds/new-css-property-filter-syntax element hiding emulation filters], e.g. `example.com#?#selector`. 
    21 - Ensure that element hiding and request blocking still works in general, including the `$domain` and `$sitekey` options. Some of the unrelated changes touched code related to `$sitekey`. 
     18- Ensure that the extension has begun working on Chrome 49 again. Smoke test all functionality, checking for exceptions in the console for the background page, options page and popup. Also make sure to test [https://adblockplus.org/development-builds/new-css-property-filter-syntax element hiding emulation filters], e.g. `example.com#?#selector`, especially with compound selectors in the document (see #6619). 
     19- Test that whitespace in snippet filters works as specified in #6538 and in the testing hints in #6782. e.g. `example.com#$#log Hello; log 'How are you?'` should call the `log` snippet twice; the console should show "Hello" and "How are you?", each on its own line, in that order. 
    2220- Test the `hide-if-contains` snippet, see #6809.