Changes between Version 3 and Version 11 of Ticket #6841


Ignore:
Timestamp:
08/08/2018 02:37:09 PM (15 months ago)
Author:
kzar
Comment:

Coming up with a patch for that...

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #6841

    • Property Owner set to kzar
    • Property Priority changed from Unknown to P1
    • Property Ready set
    • Property Component changed from Core to Platform
  • Ticket #6841 – Description

    v3 v11  
    1616=== Expected behaviour === 
    1717Snippets to work in Chrome 49 (unless there is a reason they cannot). 
     18 
     19=== Notes === 
     20- `adblockpluschrome/lib/contentFiltering.js` is calling `browser.tabs.executeScript`, passing a `frameId` of `0` which causes an exception in Chrome 49 (which we silently ignore): 
     21 
     22{{{ 
     23browser.tabs.executeScript failed Error: Invalid value for argument 2. Property 'frameId': Unexpected property. 
     24    at validate (extensions::schemaUtils:34:13) 
     25    at Object.normalizeArgumentsAndValidate (extensions::schemaUtils:117:3) 
     26    at Object.<anonymous> (extensions::binding:374:30) 
     27    at Object.value [as executeScript] (chrome-extension://ffiagampjdjojfgakjeeoipjmfmkahnn/polyfill.js:108:14) 
     28    at executeScript (chrome-extension://ffiagampjdjojfgakjeeoipjmfmkahnn/lib/adblockplus.js:11490:18) 
     29    at port.on (chrome-extension://ffiagampjdjojfgakjeeoipjmfmkahnn/lib/adblockplus.js:11537:9) 
     30    at Object._onMessage (chrome-extension://ffiagampjdjojfgakjeeoipjmfmkahnn/lib/adblockplus.js:3758:22) 
     31    at Object._dispatch (chrome-extension://ffiagampjdjojfgakjeeoipjmfmkahnn/ext/common.js:41:22) 
     32    at browser.runtime.onMessage.addListener (chrome-extension://ffiagampjdjojfgakjeeoipjmfmkahnn/ext/background.js:604:26) 
     33    at wrapper (chrome-extension://ffiagampjdjojfgakjeeoipjmfmkahnn/polyfill.js:156:20) 
     34}}} 
     35- If we instead omit the `frameId` if it's `0` it starts working again.