Changes between Version 13 and Version 17 of Ticket #6841


Ignore:
Timestamp:
08/09/2018 05:30:26 AM (15 months ago)
Author:
mjethani
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #6841

    • Property Status changed from reviewing to closed
    • Property Cc rscott added
    • Property Milestone changed from to Adblock-Plus-3.3-for-Chrome-Opera-Firefox
    • Property Resolution changed from to fixed
  • Ticket #6841 – Description

    v13 v17  
    3434}}} 
    3535- If we instead omit the `frameId` if it's `0`, [https://developer.chrome.com/extensions/tabs#method-executeScript which is the default value anyway], it starts working again 
     36 
     37=== Hints for testers === 
     38Given the filter `127.0.0.1#$#log 'Hello from the main frame'` and the following document loaded off 127.0.0.1: 
     39 
     40{{{ 
     41<html> 
     42  <body> 
     43    <h1>Main Frame</h1> 
     44    <iframe src="http://example.com"></iframe> 
     45  </body> 
     46</html> 
     47}}} 
     48 
     49You should see only ''one'' instance of the text "Hello from the main frame" printed to the console. Likewise, changing the filter to `example.com#$#log 'Hello from example.com'` should print "Hello from example.com" only ''once''. But changing the filter to `127.0.0.1,example.com#$#log 'Hello'` should print "Hello" ''twice''. 
     50 
     51Please test this on both Chrome and Firefox.