#6844 closed change (fixed)

Update buildtools dependency to 1b51de5f632c

Reported by: tlucas Assignee: tlucas
Priority: P2 Milestone:
Module: Platform Keywords:
Cc: geo, oleksandr, sebastian, kzar Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29851630

Description (last modified by kzar)

Background

In #6291, we introduced ManifoldJS as our packager for Edge. We now want to actually use this.

Included changes in buildtools

The list of changes imported by this is:


a8b5bbe92c0a Noissue - Adapt best practices for trailing commas Sebastian Noack

What to change

Update the buildtools dependency in adblockpluschrome's edge bookmark to:

mercurial git
1b51de5f632c 444c380

According to the integration notes in #6625, add a note for webpack's resolve.alias to the README.md.

Integration Notes

An increased run-time for the builds for edge is expected.

Hints for testers

The builds itself should not change at all, we'll verify that, so no further testing is necessary.

Change History (6)

comment:1 Changed 16 months ago by tlucas

  • Review URL(s) modified (diff)

comment:2 Changed 16 months ago by kzar

  • Description modified (diff)
  • Priority changed from Unknown to P2
  • Ready set

comment:3 Changed 16 months ago by tlucas

  • Owner set to tlucas

comment:4 Changed 16 months ago by tlucas

  • Status changed from new to reviewing

comment:5 Changed 16 months ago by abpbot

A commit referencing this issue has landed:
Issue 6844 - Update buildtools to 1b51de5f632c / 444c380

comment:6 Changed 16 months ago by tlucas

  • Resolution set to fixed
  • Status changed from reviewing to closed
  • Verified working set
Note: See TracTickets for help on using tickets.