Opened on 08/09/2018 at 07:38:06 AM

Closed on 08/09/2018 at 09:53:17 AM

#6844 closed change (fixed)

Update buildtools dependency to 1b51de5f632c

Reported by: tlucas Assignee: tlucas
Priority: P2 Milestone:
Module: Platform Keywords:
Cc: geo, oleksandr, sebastian, kzar Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: yes
Review URL(s):

Description (last modified by kzar)


In #6291, we introduced ManifoldJS as our packager for Edge. We now want to actually use this.

Included changes in buildtools

The list of changes imported by this is:

a8b5bbe92c0a Noissue - Adapt best practices for trailing commas Sebastian Noack

What to change

Update the buildtools dependency in adblockpluschrome's edge bookmark to:

mercurial git
1b51de5f632c 444c380

According to the integration notes in #6625, add a note for webpack's resolve.alias to the

Integration Notes

An increased run-time for the builds for edge is expected.

Hints for testers

The builds itself should not change at all, we'll verify that, so no further testing is necessary.

Attachments (0)

Change History (6)

comment:1 Changed on 08/09/2018 at 07:46:36 AM by tlucas

  • Review URL(s) modified (diff)

comment:2 Changed on 08/09/2018 at 09:28:47 AM by kzar

  • Description modified (diff)
  • Priority changed from Unknown to P2
  • Ready set

comment:3 Changed on 08/09/2018 at 09:40:15 AM by tlucas

  • Owner set to tlucas

comment:4 Changed on 08/09/2018 at 09:40:23 AM by tlucas

  • Status changed from new to reviewing

comment:5 Changed on 08/09/2018 at 09:52:21 AM by abpbot

A commit referencing this issue has landed:
Issue 6844 - Update buildtools to 1b51de5f632c / 444c380

comment:6 Changed on 08/09/2018 at 09:53:17 AM by tlucas

  • Resolution set to fixed
  • Status changed from reviewing to closed
  • Verified working set

Add Comment

Modify Ticket

Change Properties
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from tlucas.
Note: See TracTickets for help on using tickets.