Opened 18 months ago

Last modified 16 months ago

#6845 closed change

Remove translatable strings from adblockpluschrome — at Version 4

Reported by: kzar Assignee:
Priority: P2 Milestone:
Module: Unknown Keywords:
Cc: sebastian, greiner Blocked By: #6633
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description (last modified by kzar)

Background

We plan to move the translatable strings over from adblockpluschrome to adblockplusui. With #6633 we're adding the files to adblockplusui, so now we need to remove them from adblockpluschrome and update the metadata.

What to change

  • Remove all the locale files.
  • Update the [import_locales] section of metadata.chrome to import those files from adblockplusui.

Hints for testers

  • Check that all the moved translatable strings still work (aren't blank). For a complete list of the strings see Thomas' summary.
  • The following functionality uses those strings:
    • "Block element" tool
    • issue reporter
    • Adblock Plus popup (when you click the ABP icon)
    • notifications

The invalid filter error messages have also been moved, some example filters:

String nameTriggering filter
filter_elemhideemulation_nodomain #?#foo
filter_snippet_nodomain #$#foo
filter_invalid_csp adblockplus.org$csp=base-uri
filter_invalid_domain ,##foo
filter_invalid_regexp
filter_unknown_option $foo
invalid_css_selector
unexpected_filter_list_header

Change History (4)

comment:1 Changed 18 months ago by kzar

Thomas can you help fill in the blanks in the table? I'm trying to figure out examples of filters which the testers can use for the various error messages.

comment:2 Changed 18 months ago by kzar

  • Description modified (diff)

comment:3 Changed 18 months ago by kzar

  • Description modified (diff)

comment:4 Changed 18 months ago by kzar

  • Description modified (diff)
Note: See TracTickets for help on using tickets.