Opened 4 months ago

Closed 3 months ago

Last modified 7 weeks ago

#6846 closed change (fixed)

Add new error message for invalid snippet filters

Reported by: greiner Assignee: saroyanm
Priority: P2 Milestone:
Module: User-Interface Keywords:
Cc: kzar, mjethani Blocked By: #6797
Blocking: #6892 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://gitlab.com/eyeo/adblockplus/abpui/adblockplusui/merge_requests/104

Change History (10)

comment:1 Changed 3 months ago by saroyanm

We are referencing #6896 in the #6892, I assume this needs to be closed, or referenced instead.

comment:2 Changed 3 months ago by greiner

  • Blocking 6892 added
  • Priority changed from Unknown to P2
  • Ready set

comment:3 Changed 3 months ago by saroyanm

  • Owner set to saroyanm

comment:4 Changed 3 months ago by saroyanm

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:5 follow-up: Changed 3 months ago by mjethani

I just saw diff, this needs to be "snippet filter" rather than "element hiding filter".

comment:6 in reply to: ↑ 5 Changed 3 months ago by saroyanm

Replying to mjethani:

I just saw diff, this needs to be "snippet filter" rather than "element hiding filter".

Thanks Manish, updated.

comment:7 Changed 3 months ago by greiner

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:8 Changed 3 months ago by mjethani

This looks right, thanks!

comment:9 Changed 3 months ago by abpbot

comment:10 Changed 7 weeks ago by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Done. Working as described. Looks translated correctly.

ABP 3.3.2.2175
Firefox 62 / 51 / Windows 10
Chrome 69 / 49 / Windows 10
Opera 56 / 36 / Windows 10

Note: See TracTickets for help on using tickets.