Opened 2 years ago

Closed 23 months ago

Last modified 21 months ago

#6862 closed change (fixed)

Make Snippets module emit events

Reported by: mjethani Assignee: mjethani
Priority: P2 Milestone:
Module: Core Keywords: circumvention
Cc: kzar Blocked By:
Blocking: #6538, #6826 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29856564/
https://codereview.adblockplus.org/29869555/

Description (last modified by mjethani)

Background

For #6826, the Snippets module will have to notify any listeners when a new filter is added or an existing one removed (see patch #29856567).

What to change

Make the Snippets module in lib/snippets.js emit events for the addition, removal, and clearing of filters.

Hints for testers

Make sure that snippet filters are working in general.

Change History (8)

comment:1 Changed 2 years ago by mjethani

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 2 years ago by mjethani

  • Blocking 6826 added

comment:3 Changed 23 months ago by abpbot

A commit referencing this issue has landed:
Issue 6862 - Make Snippets module emit events

comment:4 Changed 23 months ago by mjethani

  • Review URL(s) modified (diff)

comment:5 Changed 23 months ago by abpbot

A commit referencing this issue has landed:
Issue 6862 - Add tests for Snippets module events

comment:6 Changed 23 months ago by mjethani

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:7 Changed 23 months ago by mjethani

  • Description modified (diff)

comment:8 Changed 21 months ago by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Done. Snippets appear to be working in general.

ABP 3.3.2.2175
Firefox 62 / 51 / Windows 10
Chrome 69 / 49 / Windows 10
Opera 56 / 36 / Windows 10

Note: See TracTickets for help on using tickets.