Opened 16 months ago

Closed 16 months ago

Last modified 14 months ago

#6876 closed change (fixed)

Update code to work with Filter.prototype.subscriptions as a Set object

Reported by: greiner Assignee: greiner
Priority: P1 Milestone:
Module: User-Interface Keywords:
Cc: wspee, mjethani, kzar Blocked By:
Blocking: #6933 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://gitlab.com/eyeo/adblockplus/abpui/adblockplusui/merge_requests/94

Description (last modified by greiner)

Background

Filter.prototype.subscriptions is now a Set object (see https://issues.adblockplus.org/ticket/6559#comment:27).

What to change

Modify any code that assumes the type of Filter.prototype.subscriptions to be Array, treat it as a Set object now.

See also ui#166

Hints for testers

Requests and filters should show up as expected in DevTools panel.

Change History (10)

comment:1 Changed 16 months ago by greiner

  • Description modified (diff)

comment:2 Changed 16 months ago by greiner

  • Description modified (diff)
  • Priority changed from Unknown to P1
  • Ready set

comment:3 Changed 16 months ago by greiner

  • Owner set to greiner

comment:4 Changed 16 months ago by greiner

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:5 Changed 16 months ago by greiner

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:6 Changed 16 months ago by greiner

  • Blocking 6892 added

comment:7 Changed 16 months ago by greiner

  • Description modified (diff)

Added hints for testers.

comment:8 Changed 15 months ago by greiner

  • Blocking 6933 added; 6892 removed

comment:10 Changed 14 months ago by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Done. Requests and filters appear in the devtools log as expected.

ABP 3.3.2.2175
Firefox 62 / 51 / Windows 10
Chrome 69 / 49 / Windows 10
Opera 56 / 36 / Windows 10

Note: See TracTickets for help on using tickets.