Opened 15 months ago

Closed 15 months ago

Last modified 13 months ago

#6878 closed change (fixed)

Implement IOFilterSearch

Reported by: agiammarchi Assignee: agiammarchi
Priority: P3 Milestone:
Module: User-Interface Keywords:
Cc: Blocked By:
Blocking: #6892 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://gitlab.com/eyeo/adblockplus/abpui/adblockplusui/merge_requests/92

Description

A complementary component for https://issues.adblockplus.org/ticket/6875 able to dispatch filter:add or filter:show events and handle user interaction.

Specs: https://gitlab.com/eyeo/specs/spec/merge_requests/149

Change History (8)

comment:1 Changed 15 months ago by greiner

  • Blocking 6892 added

comment:2 Changed 15 months ago by greiner

  • Owner set to agiammarchi
  • Priority changed from Unknown to P3
  • Ready set

comment:3 Changed 15 months ago by greiner

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:6 Changed 13 months ago by Ross

I'm not sure if I'm able to test this yet? It looks like background work for a new custom filter list in a future release?

comment:7 Changed 13 months ago by agiammarchi

Ross that's correct. This component is not used yet in the UI but, as other components that were flagged ready, it landed in the release.

The build process won't even include the CSS, nor the JS, so this component can be safely ignored for release 3.4.

comment:8 Changed 13 months ago by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Okay thanks. Verifying this as it doesn't look to have caused any issues or side effects.

ABP 3.3.2.2176
Firefox 62 / 51 / Windows 10
Chrome 69 / 49 / Windows 10
Opera 56 / 36 / Windows 10

Note: See TracTickets for help on using tickets.