Opened 16 months ago

Closed 16 months ago

Last modified 12 months ago

#6879 closed change (fixed)

Update adblockplusui dependency to 476bd7fa39b6

Reported by: saroyanm Assignee:
Priority: P1 Milestone: Adblock-Plus-3.3-for-Chrome-Opera-Firefox
Module: Platform Keywords:
Cc: kzar, sebastian, wspee Blocked By: #6866
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29861582/

Description

Background

Lately we have noticed that the Icons on newer Firefox Version are broken. See -> https://gitlab.com/eyeo/adblockplus/abpui/adblockplusui/issues/165 and https://gitlab.com/eyeo/adblockplus/abpui/adblockplusui/merge_requests/90

It would be great to have this changes in the release of ABP 3.3 if possible.

What to change

Update the adblockplusui dependency to hg: 476bd7fa39b6 git: 4cf24d8


Hints for testers

Ensure that Delete and Checkmark Icons are accessible on the Firefox Mobile.

Change History (7)

comment:1 Changed 16 months ago by saroyanm

  • Cc kzar sebastian wspee added
  • Component changed from Unknown to Platform

@Sebastian and @Winsley agreed that it's possible to land this change for the ABP V3.3 release.

Thanks a lot for being flexible regarding this change, I missed this issue, as the icon was accessible on the old FF, even on FF59 the icons were accessible.

I'll prepare also the patch and move forward after this ticket is made ready.

comment:2 Changed 16 months ago by saroyanm

  • Review URL(s) modified (diff)

comment:3 Changed 16 months ago by abpbot

A commit referencing this issue has landed:
Issue 6879 - Update adblockplusui dependency to 476bd7fa39b6

comment:4 Changed 16 months ago by sebastian

  • Milestone set to Adblock-Plus-3.3-for-Chrome-Opera-Firefox
  • Priority changed from Unknown to P1
  • Ready set
  • Resolution set to fixed
  • Status changed from new to closed

comment:5 Changed 16 months ago by Ross

This looks fixed for me on the device below. Will check another device shortly.

ABP 3.2.0.2107
Firefox 61
Galaxy J5 / Android 7.1.1

comment:6 Changed 16 months ago by rscott

  • Verified working set

Fixed for me as well on 2107/FF61/Pixel/Android 9.0. Thanks for this!

comment:7 Changed 12 months ago by greiner

  • Blocked By 6866 added
Note: See TracTickets for help on using tickets.