Opened 10 months ago

Closed 10 months ago

Last modified 9 months ago

#6881 closed change (fixed)

[adblockpluschrome] Update adblockpluscore dependency to 4a504a8ac939

Reported by: tlucas Assignee: tlucas
Priority: P2 Milestone: Adblock-Plus-3.4-for-Chrome-Opera-Firefox
Module: Platform Keywords:
Cc: sebastian, kzar, hfiguiere, mjethani Blocked By:
Blocking: #6717 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29863596

Description

Background

In #6717, adblockpluschrome will require a file from adblockpluscore, which is not yet present in the current depedency.

Included changes in adblockpluscore

The list of changes imported by this is:


What to change

Update the adblockpluscore dependency to:

mercurial git
4a504a8ac939 e752ad4

Hints for testers

Please find potential tasks in the tickets for the included changes, otherwise nothing should change.

Change History (9)

comment:1 Changed 10 months ago by tlucas

  • Blocking 6717 removed

comment:2 Changed 10 months ago by tlucas

  • Blocking 6717 added

comment:3 Changed 10 months ago by sebastian

  • Priority changed from Unknown to P2
  • Ready set

comment:4 Changed 10 months ago by tlucas

  • Owner set to tlucas

comment:5 Changed 10 months ago by tlucas

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:6 Changed 10 months ago by abpbot

A commit referencing this issue has landed:
Issue 6881 - Update adblockpluscore to 4a504a8ac939 / e752ad4

comment:7 Changed 10 months ago by tlucas

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:8 Changed 10 months ago by sebastian

  • Milestone set to Adblock-Plus-for-Chrome-Opera-Firefox-next

comment:9 Changed 9 months ago by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Done. Checked that snippets still work and browser tests run in Firefox.

ABP 3.3.2.2164
Chrome 69 / 49 / Windows 10
Firefox 62 / 51 / Windows 10

Note: See TracTickets for help on using tickets.