Opened 10 months ago

Closed 10 months ago

Last modified 9 months ago

#6882 closed defect (fixed)

[npm test] Firefox zombies remain when qunit tests fail

Reported by: tlucas Assignee:
Priority: P2 Milestone: Adblock-Plus-3.4-for-Chrome-Opera-Firefox
Module: Platform Keywords:
Cc: sebastian, kzar, hfiguiere Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29864558/

Description

Environment

Debian 9
Firefox 57
adblockpluschrome @ d29f5ec / 44766c66877b

How to reproduce

  1. Mock one of the qunit-tests to fail, e.g. change line 14 in qunit/test/cssEscaping.js from
          let mustMatch = opts.mustMatch !== false;
    
    to
          let mustMatch = opts.mustMatch !== true;
    
  1. Completely shutdown every Firefox-process that might be running on your machine
  2. Install the dependencies to run the tests: $ npm install
  3. Execute the tests: $ npm test
  4. Monitor existing Firefox processes with e.g. htop, with a filter set to firefox

Observed behaviour

The tests fail with Assertion Message: CSS escaping, the firefox process remains in memory.

Expected behaviour

The tests should fail with Assertion Message: CSS escaping, the firefox process should be completely shut down and vanish from memory, no processes should remain.

Change History (6)

comment:1 Changed 10 months ago by tlucas

  • Status changed from new to reviewing

comment:2 Changed 10 months ago by tlucas

  • Review URL(s) modified (diff)

comment:3 Changed 10 months ago by abpbot

A commit referencing this issue has landed:
Issue 6882 - always shutdown the browser gracefully

comment:4 Changed 10 months ago by tlucas

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:5 Changed 10 months ago by sebastian

  • Milestone set to Adblock-Plus-for-Chrome-Opera-Firefox-next

comment:6 Changed 9 months ago by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Fixed. Firefox instances are shutdown if tests fail.

adblockpluschrome / master / 2164:856217ee8673

Note: See TracTickets for help on using tickets.