Opened 13 months ago

Closed 13 months ago

Last modified 11 months ago

#6883 closed change (fixed)

Remove Filter.toRegExp function

Reported by: mjethani Assignee: jsonesen
Priority: P4 Milestone:
Module: Core Keywords:
Cc: kzar, sergz, jsonesen, greiner, sebastian Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

Description (last modified by mjethani)

Background

It's not clear exactly why Filter.toRegExp exists, especially since it is merely an alias for filterToRegExp in lib/common.js. This function is not being used anywhere outside of lib/filterClasses.js itself.

What to change

Remove Filter.toRegExp and use filterToRegExp directly.

Hints for testers

This is a minor change already covered by unit tests.

Change History (9)

comment:1 Changed 13 months ago by mjethani

  • Cc jsonesen greiner added

comment:2 Changed 13 months ago by mjethani

  • Cc sebastian added

comment:3 Changed 13 months ago by mjethani

If no one has any objections, I'd like to remove this function.

comment:4 Changed 13 months ago by jsonesen

  • Owner set to jsonesen

comment:5 Changed 13 months ago by greiner

No objections from me.

comment:6 Changed 13 months ago by abpbot

A commit referencing this issue has landed:
Issue 6883 - Use filterToRegExp in lib/filterClasses.js

comment:7 Changed 13 months ago by mjethani

  • Ready set

comment:8 Changed 13 months ago by mjethani

  • Description modified (diff)
  • Resolution set to fixed
  • Status changed from new to closed

comment:9 Changed 11 months ago by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Done. Unit tests pass and does not look to have caused any regressions.

ABP 3.3.2.2175
Firefox 62 / 51 / Windows 10
Chrome 69 / 49 / Windows 10
Opera 56 / 36 / Windows 10

Note: See TracTickets for help on using tickets.