Changes between Version 1 and Version 2 of Ticket #6884


Ignore:
Timestamp:
08/25/2018 11:20:04 PM (15 months ago)
Author:
sebastian
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #6884 – Description

    v1 v2  
    11=== Background === 
    2 With #6717 we introduced `nodeuntit` in `adblockpluschrome` in order to wrap WebDriver to run the actual (qunit) tests from the command line and the CI. We decided to use `nodeunit` becasue this is historically what we use in `adblockpluscore` (we might want to migrate to Mocha there as well). 
     2With #6717 we introduced `nodeunit` in `adblockpluschrome` in order to wrap WebDriver to run the actual (qunit) tests from the command line and the CI. We decided to use `nodeunit` becasue this is historically what we use in `adblockpluscore` (we might want to migrate to Mocha there as well). 
    33 
    44There are following issues with `nodeunit`: 
     
    1010The latter two make it in particular impossible to extend the test suite (e.g. by running against our [https://testpages.adblockplus.org test pages]), without resulting into an inferior test architecture and slower performance. 
    1111 
     12Mocha doesn't seem to have any of this issue and appears to have become the defacto standard testing framework for Node.js in modern days. 
     13 
    1214=== What to change === 
    1315Replace `nodeunit`with the Mocha test framework in `adblockpluchrome`. While on it, leverage the `before` and `after` hooks (which wasn't possible before and will help to add more tests).