Opened on 08/28/2018 at 08:20:42 AM

Closed on 09/06/2018 at 05:31:14 PM

Last modified on 10/24/2018 at 08:05:34 AM

#6890 closed change (fixed)

[Gitlab CI] Add a job for testing Adblock Plus on Chromium with xvfb

Reported by: tlucas Assignee: tlucas
Priority: P3 Milestone: Adblock-Plus-3.4-for-Chrome-Opera-Firefox
Module: Platform Keywords:
Cc: sebastian, sergz, kzar Blocked By: #6887
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

Description (last modified by tlucas)


As soon as #6651 is landed, we will have the qunit tests for Adblock Plus run automatically on Firefox, everytime something is pushed.

We originally wanted to achieve this with Chrome / Chromium, which now was deemed possible when we use xvfb. In #6887, we add the additional target to npm test, we now want CI to actually use this.

What to change

  • Add an additional job to adblockpluschrome's CI-configuration, which runs npm test for the target chrome via `xvfb:
     - xvfb-run npm test -- -g chrome
  • Let this job run in parallel to the testing on Firefox
  • Let - if possible - and npm install only one time fully execute, in order to minimize execution time

Attachments (0)

Change History (6)

comment:1 Changed on 08/28/2018 at 08:29:50 AM by tlucas

  • Blocked By 6887 added
  • Cc sebastian sergz kzar added
  • Component changed from Unknown to Platform
  • Description modified (diff)
  • Milestone set to Adblock-Plus-for-Chrome-Opera-Firefox-next
  • Priority changed from Unknown to P3
  • Ready set

comment:2 Changed on 08/28/2018 at 08:36:34 AM by tlucas

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed on 09/06/2018 at 05:00:56 PM by abpbot

A commit referencing this issue has landed:
Issue 6890 - run npm tests in parallel

comment:4 Changed on 09/06/2018 at 05:30:51 PM by tlucas

  • Owner set to tlucas

comment:5 Changed on 09/06/2018 at 05:31:14 PM by tlucas

  • Blocked By 6651 removed
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:6 Changed on 10/24/2018 at 08:05:34 AM by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

I can see the CI changes on GitLab and see attempted CI runs. They seem to fail currently, but this ticket is for adding them so will mark verified.

Add Comment

Modify Ticket

Change Properties
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from tlucas.
Note: See TracTickets for help on using tickets.