Opened 10 months ago

Closed 9 months ago

Last modified 8 months ago

#6892 closed change (fixed)

Update adblockplusui dependency to hg:7386698260f4 (release-2018-4)

Reported by: greiner Assignee: greiner
Priority: P2 Milestone: Adblock-Plus-3.4-for-Chrome-Opera-Firefox
Module: Platform Keywords:
Cc: wspee, sebastian, saroyanm Blocked By: #5851, #6171, #6633, #6659, #6712, #6736, #6740, #6742, #6749, #6751, #6758, #6759, #6760, #6768, #6779, #6788, #6792, #6794, #6795, #6800, #6801, #6816, #6818, #6827, #6828, #6838, #6846, #6846, #6852, #6864, #6878, #6895, #6896, #6898, #6903, #6911, #6922, #6933, #6935
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29879555/

Description (last modified by greiner)

Background

This import the follow changes:

Ticket Status Resolution Summary Component Owner
#5851 closed fixed Layout shifts after opening Custom subscription popup in new options page User-Interface greiner
#6171 closed fixed Allow to import and export translations to a csv file User-Interface saroyanm
#6633 closed fixed Move translatable strings from adblockpluschrome to adblockplusui User-Interface saroyanm
#6659 closed fixed Remove term "URL link" User-Interface greiner
#6712 closed fixed Updated tooltip for toggling notifications User-Interface greiner
#6736 closed fixed Make Show useful notifications option persistent on the advanced tab of the options page User-Interface saroyanm
#6740 closed fixed Add option to show/hide number in icon to options page User-Interface greiner
#6742 closed fixed Update title of Customization section in options page User-Interface saroyanm
#6749 closed fixed Make first-run page consistent with website installation flow User-Interface greiner
#6751 closed fixed Issue reporter: Screenshot feature User-Interface agiammarchi
#6758 closed fixed Make tooltips open on click User-Interface greiner
#6759 closed fixed Update custom filter list texts User-Interface greiner
#6760 closed fixed Don't show filter list title if none passed via subscribe link User-Interface greiner
#6768 closed fixed Remove "NEW" label from Acceptable Ads without 3rd party tracking User-Interface saroyanm
#6779 closed fixed CSV exporter throws error User-Interface saroyanm
#6788 closed fixed Integrate stylelint-config-eyeo into adblockplusui User-Interface greiner
#6792 closed fixed Import translations from agencies for commit 7a81f567 User-Interface saroyanm
#6794 closed fixed Bubble UI: UX improvements [UX] User-Interface agiammarchi
#6795 closed fixed Highlighter area coordinates offset by scrolling User-Interface agiammarchi
#6800 closed fixed Regression: Issue report data is incomplete User-Interface agiammarchi
#6801 closed fixed Improved state for non http/s protocols User-Interface agiammarchi
#6816 closed fixed Bubble UI: Add heading "Number of items blocked" User-Interface agiammarchi
#6818 closed fixed Provide a way to make attribute values translatable in a declarative way User-Interface greiner
#6827 closed fixed Issue reporter data overlay doesn't include screenshot User-Interface agiammarchi
#6828 closed fixed Issue Reporter - reported data link breaks + cancel button User-Interface agiammarchi
#6838 closed fixed Sometimes all subscriptions are listed as additional subscriptions User-Interface greiner
#6846 closed fixed Add new error message for invalid snippet filters User-Interface saroyanm
#6852 closed fixed Run linter on gitlab ci for all commits User-Interface wspee
#6864 closed fixed ABP UI Nightlies User-Interface wspee
#6878 closed fixed Implement IOFilterSearch User-Interface agiammarchi
#6895 closed fixed Finish issue reporter styles User-Interface agiammarchi
#6896 closed duplicate Add new error message for invalid snippet filters User-Interface
#6898 closed fixed Duplicate "add" string User-Interface saroyanm
#6903 closed fixed Add mssing data to the submitted report User-Interface saroyanm
#6911 closed fixed Broken CSS query for [data-i18n-${attr}] User-Interface
#6922 closed fixed Allows any kind of notification in the new Bubble UI User-Interface agiammarchi
#6933 closed fixed Update adblockpluscore to dcda4859fcbd (and adblockplusui for compatibility) Platform
#6935 closed fixed IOBigToggle not rendered User-Interface


It also imports the following Noissue changes:

  • Add 3rd parts license used by latest components
  • Added Bubble UI Translations
  • Added build directory to linting
  • fixed breaking typo with the package
  • Fixed: Added missing hit logger mocks
  • Fixed: Build scripts were ignored by linter
  • Fixed: ESLint didn't consider js directory
  • Fixed: Popup icons rendered with button styles
  • Fixed: prefer-const linting errors
  • Fixed: Remember filter lists added by update attempt
  • Implement IOScrollbar for infinite scroll
  • package.json dependencies update
  • Remove MR left over
  • Removed unused issue-reporter.js
  • Structured package.json
  • update dependencies
  • updated npm-dollar package
  • use more readable CSV example in the README

What to change

  • Change adblockplusui dependency to hg:7386698260f4 git:ab57a6b
  • Apply necessary changes (see release-2018-4)

Hints for testers

Everything should be implemented according to the spec.
See also hints for testers section in the individual tickets.

Missing information

We're still waiting for translations before we can say which revision should be used.

Change History (66)

comment:1 Changed 10 months ago by greiner

  • Component changed from User-Interface to Platform
  • Description modified (diff)
  • Summary changed from Update adblockplusui dependency to TBD (release-2018-5) to Update adblockplusui dependency to TBD (release-2018-4)

comment:2 Changed 10 months ago by greiner

  • Blocked By 6633 added

comment:3 Changed 10 months ago by greiner

  • Description modified (diff)

comment:4 Changed 10 months ago by greiner

  • Blocked By 6659 added

comment:5 Changed 10 months ago by greiner

  • Blocked By 6633 removed

comment:6 Changed 10 months ago by greiner

  • Blocked By 6633 added

comment:7 Changed 10 months ago by greiner

  • Description modified (diff)

comment:8 Changed 10 months ago by greiner

  • Blocked By 6712 added

comment:9 Changed 10 months ago by greiner

  • Blocked By 6736 added

comment:10 Changed 10 months ago by greiner

  • Blocked By 6742 added

comment:11 Changed 10 months ago by greiner

  • Blocked By 6749 added

comment:12 Changed 10 months ago by greiner

  • Blocked By 6751 added

comment:13 Changed 10 months ago by greiner

  • Blocked By 6758 added

comment:14 Changed 10 months ago by greiner

  • Blocked By 6759 added

comment:15 Changed 10 months ago by greiner

  • Blocked By 6760 added

comment:16 Changed 10 months ago by greiner

  • Blocked By 6768 added

comment:17 Changed 10 months ago by greiner

  • Blocked By 6788 added

comment:18 Changed 10 months ago by greiner

  • Blocked By 6794 added

comment:19 Changed 10 months ago by greiner

  • Blocked By 6795 added

comment:20 Changed 10 months ago by greiner

  • Blocked By 6800 added

comment:21 Changed 10 months ago by greiner

  • Blocked By 6801 added

comment:22 Changed 10 months ago by greiner

  • Blocked By 6816 added

comment:23 Changed 10 months ago by greiner

  • Blocked By 6818 added

comment:24 Changed 10 months ago by greiner

  • Blocked By 6827 added

comment:25 Changed 10 months ago by greiner

  • Blocked By 6828 added

comment:26 Changed 10 months ago by greiner

  • Blocked By 6838 added

comment:27 Changed 10 months ago by greiner

  • Blocked By 6876 added

comment:28 Changed 10 months ago by greiner

  • Blocked By 6878 added

comment:29 Changed 10 months ago by greiner

  • Description modified (diff)

comment:30 Changed 10 months ago by greiner

  • Blocked By 6171 added

comment:31 Changed 10 months ago by greiner

  • Blocked By 6779 added

comment:32 Changed 10 months ago by greiner

  • Blocked By 6792 added

comment:33 Changed 10 months ago by greiner

  • Blocked By 6852 added

comment:34 Changed 10 months ago by greiner

  • Blocked By 6864 added

comment:35 Changed 10 months ago by greiner

  • Blocked By 6895 added

comment:36 Changed 10 months ago by greiner

  • Blocked By 6896 added

comment:37 Changed 10 months ago by greiner

  • Cc sebastian added

comment:38 Changed 10 months ago by saroyanm

  • Blocked By 6898 added

comment:39 Changed 10 months ago by saroyanm

  • Cc saroyanm added

comment:40 Changed 10 months ago by greiner

  • Description modified (diff)

Added hints for testers.

comment:41 Changed 10 months ago by saroyanm

  • Blocked By 6903 added

comment:42 Changed 10 months ago by greiner

  • Blocked By 6907 added

comment:43 Changed 10 months ago by greiner

  • Blocked By 6921 added

comment:44 Changed 10 months ago by agiammarchi

  • Blocked By 6922 added

comment:45 Changed 10 months ago by greiner

  • Blocked By 6846 added

comment:46 Changed 10 months ago by saroyanm

  • Blocked By 6898 removed

comment:47 Changed 10 months ago by saroyanm

  • Blocked By 6898 added

comment:48 Changed 9 months ago by greiner

  • Blocked By 6933 added

comment:49 Changed 9 months ago by greiner

  • Blocked By 6907 removed

comment:50 Changed 9 months ago by greiner

  • Blocked By 6921 removed

comment:51 Changed 9 months ago by greiner

  • Blocked By 6876 removed

comment:52 Changed 9 months ago by greiner

  • Blocked By 5851 added

comment:53 Changed 9 months ago by greiner

  • Blocked By 6935 added

comment:54 Changed 9 months ago by greiner

See also #6684.

comment:55 Changed 9 months ago by greiner

See also #6321.

comment:56 Changed 9 months ago by sebastian

  • Priority changed from Unknown to P2
  • Ready set

I just discussed with Winsley to perform this dependency update as soon as possible (without waiting any longer for the translations), and then have another dependency update once the translations are ready (latest in two weeks).

comment:57 Changed 9 months ago by greiner

  • Owner set to greiner

comment:58 Changed 9 months ago by greiner

  • Description modified (diff)
  • Summary changed from Update adblockplusui dependency to TBD (release-2018-4) to Update adblockplusui dependency to hg:0a78a4efe4d5 (release-2018-4)

I've now pushed git:release-2018-4 to hg:master and added the corresponding hashes to the ticket.

comment:59 Changed 9 months ago by greiner

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:60 Changed 9 months ago by greiner

  • Description modified (diff)
  • Summary changed from Update adblockplusui dependency to hg:0a78a4efe4d5 (release-2018-4) to Update adblockplusui dependency to hg:7386698260f4 (release-2018-4)

Updated ticket to include preliminary translations, as was requested during review.

comment:61 Changed 9 months ago by abpbot

A commit referencing this issue has landed:
Issue 6892 - Update adblockplusui dependency to hg:7386698260f4

comment:62 Changed 9 months ago by greiner

  • Milestone set to Adblock-Plus-for-Chrome-Opera-Firefox-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:63 Changed 9 months ago by greiner

  • Blocked By 6740 added

comment:64 Changed 9 months ago by greiner

See also #6845.

comment:65 Changed 8 months ago by greiner

  • Blocked By 6911 added

comment:66 Changed 8 months ago by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Apart from the possible notification issues in #6922 this is fine.

ABP 3.3.2.2176
Firefox 62 / 51 / Windows 10
Chrome 69 / 49 / Windows 10
Opera 56 / 36 / Windows 10

Note: See TracTickets for help on using tickets.