Opened 16 months ago

Closed 15 months ago

Last modified 12 months ago

#6898 closed change (fixed)

Duplicate "add" string

Reported by: saroyanm Assignee: saroyanm
Priority: P2 Milestone:
Module: User-Interface Keywords:
Cc: Blocked By:
Blocking: #6892 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://gitlab.com/eyeo/adblockplus/abpui/adblockplusui/merge_requests/102
https://gitlab.com/eyeo/adblockplus/abpui/adblockplusui/merge_requests/113

Description (last modified by saroyanm)

Background

https://gitlab.com/eyeo/adblockplus/abpui/adblockplusui/issues/175

What to change

Move "add" string translations from the composer.json into common.json and remove "add" source string from the composer.json

Change History (12)

comment:1 Changed 15 months ago by saroyanm

  • Description modified (diff)
  • Ready set

comment:2 Changed 15 months ago by saroyanm

  • Description modified (diff)

comment:3 Changed 15 months ago by saroyanm

  • Owner set to saroyanm

comment:4 Changed 15 months ago by saroyanm

  • Status changed from new to reviewing

comment:5 Changed 15 months ago by saroyanm

  • Review URL(s) modified (diff)

comment:6 Changed 15 months ago by saroyanm

  • Blocking 6892 removed

comment:7 Changed 15 months ago by saroyanm

  • Blocking 6892 added

comment:8 Changed 15 months ago by saroyanm

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:9 Changed 15 months ago by abpbot

A commit referencing this issue has landed:
Issue 6898 - Moved duplicate 'add' string into the common.json

comment:10 Changed 15 months ago by abpbot

comment:11 Changed 14 months ago by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Looks done. Doesn't look to have caused any problems or missing strings.

ABP 3.3.2.2175
Firefox 62 / 51 / Windows 10
Chrome 69 / 49 / Windows 10
Opera 56 / 36 / Windows 10

comment:12 Changed 12 months ago by greiner

  • Review URL(s) modified (diff)
Note: See TracTickets for help on using tickets.