Opened 5 years ago

Closed 5 years ago

Last modified 4 years ago

#690 closed change (fixed)

Issue reporter: don't consider special subscriptions when complaining about high subscription count

Reported by: trev Assignee: saroyanm
Priority: P3 Milestone: Adblock-Plus-2.6.5-for-Firefox
Module: Adblock-Plus-for-Firefox Keywords:
Cc: Ede_123 Blocked By:
Blocking: Platform: Firefox
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/5410618009976832/

Description (last modified by trev)

Background

Issue reporter currently disallows reports listing more than five filter subscription to discourage reports where people subscribed to everything on our list and to give people the feedback that this is a good idea. However, this check was implemented before acceptable ads and anti-adblock were introduced, these "special" subscriptions also count into the number.

What to change

Don't count acceptable ads and anti-adblock for the purpose of this warning.

Testing notes

This is about Firefox desktop only:

  1. In the Adblock Plus filter preferences, make sure that you have four filter subscriptions in addition to "Adblock Warning Removal List", add more if necessary. Also make sure that "Adblock Warning Removal List" and "Allow some non-intrusive advertising" are checked.
  2. Go to some webpage, click the ABP icon and select "Report issue on this page." Choose "Adblock Plus doesn't block an advertisement" as issue type and proceed - you should get to the screenshot page.
  3. Now add one more filter subscription in Adblock Plus filter preferences so that you have five now, not counting "Adblock Warning Removal List."
  4. Repeat step 2, this time you should get a message telling you to remove some filter lists.

Change History (8)

comment:1 Changed 5 years ago by philll

  • Cc Ede_123 added

by Ede_123:
(I think my last comment was eaten by the SPAM filter...?)

While changing this behaviour you should also consider

  • Some lists should probably be grouped into "families" and only counted once.

E.g. I have "EasyList", "EasyList Germany" and "EasyPrivacy" installed. At least "EasyList" and the localized counterpart "EasyList Germany" should probably only count as one list as they are meant to be used together.
(Actually these lists even exist combined into a single list, but I like the modular approach of putting together only the needed list, which after all is the reason for the limitation described in this bug - otherwise one could just use a huge "all-in-one" list and still pass the test)

  • To solve the above in a more appropriate way, you might want to consider the number of filters instead of the number of lists. E.g. five tiny lists are probably better than one huge list.

comment:2 Changed 5 years ago by trev

  • Platform set to Unknown

Five tiny lists still have five different maintainers. This limitation is about figuring out who is responsible, not about sifting through the list of filters.

comment:3 Changed 5 years ago by saroyanm

  • Owner set to saroyanm

comment:4 Changed 5 years ago by saroyanm

  • Status changed from new to reviewing

comment:5 Changed 5 years ago by saroyanm

  • Review URL(s) modified (diff)

comment:6 Changed 5 years ago by saroyanm

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:7 Changed 5 years ago by trev

  • Description modified (diff)
  • Milestone set to Adblock-Plus-for-Firefox-next
  • Platform changed from Unknown to Firefox/Firefox Mobile

comment:8 Changed 4 years ago by philll

  • Platform changed from Firefox/Firefox Mobile to Firefox

Made Firefox and Firefox mobile available as seperate platforms.

Note: See TracTickets for help on using tickets.