Opened on 08/28/2018 at 05:30:26 PM

Closed on 08/28/2018 at 05:36:36 PM

Last modified on 08/29/2018 at 03:45:57 PM

#6900 closed change (fixed)

Update adblockplusui dependency to efea71d85b24

Reported by: sebastian Assignee: sebastian
Priority: P2 Milestone: Adblock-Plus-3.3.1-for-Chrome-Opera-Firefox
Module: Platform Keywords:
Cc: agiammarchi, tlucas Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description (last modified by sebastian)


When pushing to adblockpluschrome, the development build automation generates following output (and sends it out in a cronmail):

npm WARN eslint-config-eyeo@2.1.0 requires a peer of eslint@^5.1 but none was installed.

That is because we bumped the peer dependency in eslint-config-eyeo to eslint ^5.1 while adblockplusui is still requesting eslint ^4.16.0.

Moreover, there is no point in the first place to install (and run) ESLint when adblockplusui is pulled in as a dependency.

This has been addressed in #6899 which is the only change pulled in with this dependency update.

What to change

Update the adblockplusui dependency to efea71d85b24.

Hints for testers

The change in this dependency update has no effect on the resulting builds whatsoever.

Attachments (0)

Change History (4)

comment:1 Changed on 08/28/2018 at 05:36:00 PM by abpbot

comment:2 Changed on 08/28/2018 at 05:36:36 PM by sebastian

  • Resolution set to fixed
  • Status changed from new to closed

comment:3 Changed on 08/29/2018 at 03:39:46 PM by sebastian

  • Milestone set to Adblock-Plus-3.3.1-for-Chrome-Opera-Firefox

comment:4 Changed on 08/29/2018 at 03:45:57 PM by sebastian

  • Description modified (diff)

Add Comment

Modify Ticket

Change Properties
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from sebastian.
Note: See TracTickets for help on using tickets.