#6906 closed defect (fixed)

Source archives contain wrong version number

Reported by: sebastian Assignee: tlucas
Priority: P1 Milestone:
Module: Automation Keywords:
Cc: tlucas Blocked By:
Blocking: #6910 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29869563/

Description (last modified by tlucas)

How to reproduce

Run .build.py release -t chrome -t gecko -k adblockpluschrome.pem <version> from within adblockpluschrome.

Be careful to not actually release any new version
You can mock a suitable environment by following This guide

You will find the previous generated source archives in the downloads repository.

Observed behaviour

The version in the metadata.chrome file in the generated source archives, points to the previous version before the release is performed, hence does the version of the builds generated from the source archive.

Expected behaviour

Builds generated from a source archive must have the correct version, corresponding to the version of the source code.

Change History (6)

comment:1 Changed 12 months ago by tlucas

  • Owner set to tlucas

comment:2 Changed 12 months ago by tlucas

  • Description modified (diff)

comment:3 Changed 12 months ago by tlucas

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed 12 months ago by tlucas

  • Blocking 6910 added

comment:5 Changed 12 months ago by abpbot

A commit referencing this issue has landed:
Issue 6906 - pack source archives with the correct version

comment:6 Changed 12 months ago by tlucas

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.