Opened 15 months ago

Closed 14 months ago

Last modified 13 months ago

#6907 closed change (fixed)

Adapt code to ensure compatibility with latest changes to filter notifier

Reported by: greiner Assignee: greiner
Priority: P1 Milestone:
Module: User-Interface Keywords:
Cc: Blocked By:
Blocking: #6933 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://gitlab.com/eyeo/adblockplus/abpui/adblockplusui/merge_requests/103

Description (last modified by greiner)

Background

See https://gitlab.com/eyeo/adblockplus/abpui/adblockplusui/issues/181

What to change

See https://gitlab.com/eyeo/adblockplus/abpui/adblockplusui/issues/181

Hints for testers

  • Anti-adblock notification should no longer be active (i.e. show up when visiting a web page corresponding to a domain listed in the Anti-adblock warning removal list) after removing the according filter list.
  • Anti-adblock notification should be active after adding the filter list again.
  • Adding, removing and disabling a filter list should update the UI in the settings page accordingly.

Change History (7)

comment:1 Changed 15 months ago by greiner

  • Owner set to greiner

comment:2 Changed 15 months ago by greiner

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed 15 months ago by greiner

  • Description modified (diff)

Added hints for testers.

comment:4 Changed 14 months ago by greiner

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:5 Changed 14 months ago by greiner

  • Blocking 6933 added; 6892 removed

comment:6 Changed 14 months ago by abpbot

A commit referencing this issue has landed:
Issue 6907 - Renamed FilterNotifier to filterNotifier

comment:7 Changed 13 months ago by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Done. Looks to be working as described.

ABP 3.3.2.2175
Firefox 62 / 51 / Windows 10
Chrome 69 / 49 / Windows 10
Opera 56 / 36 / Windows 10

Note: See TracTickets for help on using tickets.