Opened on 08/29/2018 at 08:04:20 PM

Closed on 08/30/2018 at 12:51:41 AM

Last modified on 08/30/2018 at 01:40:24 AM

#6909 closed defect (fixed) fails to install npm dependencies when subfolders aren't repositories

Reported by: sebastian Assignee: sebastian
Priority: P1 Milestone:
Module: Automation Keywords:
Cc: tlucas Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description (last modified by sebastian)

How to reproduce

  1. Download a source archive (e.g. adblockplus-3.3-chrome-gecko-source.tgz) from the downloads repository.
  2. Unpack the source archive.
  3. Run (or use which in turn calls the former).

Observed behaviour completes without running npm install for buildtools and adblockplusui, causing build to fail due to the lack of required Node.js packages (and not executing the postinstall hook in adblockplusui).

This is because in source archives the dependencies are already there but they are no repositories. In turn (when using Mercurial), hg id --id will produce no output on stdout (stderr and the exit code are ignored), and assumes that everything is up-to-date, skipping npm install as well.

Expected behaviour must call npm install if the dependency is contained in a directory that isn't a repository, so that build works from an unpacked source archive.

Attachments (0)

Change History (5)

comment:1 Changed on 08/29/2018 at 08:07:20 PM by sebastian

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 08/29/2018 at 08:08:53 PM by sebastian

  • Description modified (diff)

comment:3 Changed on 08/30/2018 at 12:50:43 AM by abpbot

comment:4 Changed on 08/30/2018 at 12:51:41 AM by sebastian

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:5 Changed on 08/30/2018 at 01:40:24 AM by sebastian

  • Description modified (diff)

Add Comment

Modify Ticket

Change Properties
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from sebastian.
Note: See TracTickets for help on using tickets.