Changes between Version 2 and Version 5 of Ticket #6909


Ignore:
Timestamp:
08/30/2018 01:40:24 AM (16 months ago)
Author:
sebastian
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #6909

    • Property Status changed from reviewing to closed
    • Property Resolution changed from to fixed

  • Ticket #6909 – Description

    v2 v5  
    55 
    66=== Observed behaviour === 
    7 `ensure_dependencies.py` completes without running `npm install` for `buildtools` and `adblockplusui`, causing `build.py build` to fail due to the lack of required Node.js packages. 
     7`ensure_dependencies.py` completes without running `npm install` for `buildtools` and `adblockplusui`, causing `build.py build` to fail due to the lack of required Node.js packages (and not executing the `postinstall` hook in `adblockplusui`). 
    88 
    99This is because in source archives the dependencies are already there but they are no repositories. In turn (when using Mercurial), `hg id --id` will produce no output on stdout (stderr and the exit code are ignored), and `ensure_dependencies.py` assumes that everything is up-to-date, skipping `npm install` as well.