#6913 closed defect (fixed)

Some test cases fail on Edge

Reported by: geo Assignee: geo
Priority: P2 Milestone: Adblock-Plus-3.4-for-Chrome-Opera-Firefox
Module: Platform Keywords:
Cc: sebastian, kzar Blocked By:
Blocking: Platform: Edge
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29876558/

Description

Environment

Microsoft Edge 42.17134.1.0

How to reproduce

  1. Build the extension.
  2. Check the qunit test page.

Observed behaviour

The following tests fail:
URL/host tools: Extracting hostname from URL with auth credentials
and
URL/host tools: Extracting hostname from frame with punycode

Expected behaviour

Tests should pass just like on Chrome.

Attachments (1)

tests.PNG (222.3 KB) - added by geo 15 months ago.

Download all attachments as: .zip

Change History (7)

Changed 15 months ago by geo

comment:1 Changed 15 months ago by sebastian

  • Priority changed from Unknown to P2
  • Ready set

These test failures reveal two bugs in Microsoft Edge:

  • The URL constructor throws A security problem occurred. if the given URL contains a password (e.g. new URL("http://user:password@example.com/").
  • The URL object's hostname property gives the decoded unicode, rather than the punycode representation of the hostname (e.g. new URL("http://xn--f-1gaa.com/").hostname == "föö.com").

Both is non-standard behavior, no other major browser is implementing. Can you please file those bugs with Microsoft?

Furthermore, the "Extracting hostname from URL" test is currently testing the browser's URL object rather than any of our APIs. So this test should IMO be removed. However, we might want to cover the case with the credentials as part of the "Extracting hostname from frame" test instead.

Then for the time being, let's skip the cases on Microsoft Edge that are subject to the above bugs.

Last edited 15 months ago by sebastian (previous) (diff)

comment:2 Changed 15 months ago by geo

Somebody else reported the first bug a while ago, and I've reported the second one.
Here are the links:
https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/8004284/ -> this is for credentials
https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/18861990/ -> this is for punycode

Last edited 15 months ago by geo (previous) (diff)

comment:3 Changed 15 months ago by geo

  • Owner set to geo

comment:4 Changed 15 months ago by geo

  • Review URL(s) modified (diff)

comment:5 Changed 15 months ago by abpbot

comment:6 Changed 15 months ago by sebastian

  • Milestone set to Adblock-Plus-for-Chrome-Opera-Firefox-next
  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.