Opened 10 months ago

Last modified 10 months ago

#6917 new defect

Iframe collapsing doesn't work on Firefox

Reported by: mjethani Assignee:
Priority: Unknown Milestone:
Module: Platform Keywords:
Cc: tschuster, sebastian Blocked By:
Blocking: Platform: Firefox
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description

Environment

adblockpluschrome next branch as of changeset 0954083e568e
Firefox 61

How to reproduce

  1. Follow the instructions at https://testpages.adblockplus.org/en/filters/subdocument

Observed behaviour

The request for the iframe appears to be blocked (verify in DevTools panel), but the iframe itself remains visible.

Expected behaviour

The iframe should be "collapsed" (hidden) after the request is blocked.

Additional notes

It seems the content script is not getting the error event from the iframe; oddly it gets an error event from the link element (style sheet), even though the style sheet is loaded correctly.

This issue occurs on Firefox only.

Change History (2)

comment:1 Changed 10 months ago by sebastian

  • Cc tschuster sebastian added

Frames don't get an error event on Chrome either, but we account for that by handling the load event as well specifically for frames. However, it seems on Firefox, if a frame is blocked, neither a load nor an error event is triggered. That is quite certainly a bug in Firefox.

I don't see any error event for the stylesheet.

comment:2 Changed 10 months ago by sebastian

Thanks for filing a Firefox bug, Tom!

Note: See TracTickets for help on using tickets.