Changes between Initial Version and Version 1 of Ticket #6923, comment 21


Ignore:
Timestamp:
10/31/2018 02:19:49 AM (12 months ago)
Author:
mjethani
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #6923, comment 21

    initial v1  
    1111}}} 
    1212 
    13 Now it looks like we could just have reverted it entirely. I agree about the tests. I don't see how a line starting with `!` could be treated as a filter rule. 
     13Now it looks like we could just have reverted it entirely. I agree about the tests. 
     14 
     15I don't see how a line starting with `!` could be treated as a filter rule. 
    1416 
    1517Also the `?` in `.*?` is not redundant, it makes it non-greedy. e.g. try matching `! hello : world`, it'll give you `hello ` (space) instead of `hello`, so you'd have to remove the space then.