Changes between Initial Version and Version 1 of Ticket #6923, comment 26


Ignore:
Timestamp:
10/31/2018 02:57:00 AM (12 months ago)
Author:
erikvold
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #6923, comment 26

    initial v1  
    99So now it looks like support for `!foo` was briefly added in https://gitlab.com/eyeo/adblockplus/adblockpluscore/commit/c9dc573b0c4a41b84f3dcad883876aa99d761078 for this issue and then it was removed in a following commit https://gitlab.com/eyeo/adblockplus/adblockpluscore/commit/ee3158dca717452047320cb69a80a59513997c71  
    1010 
    11 Based on what I read at https://adblockplus.org/en/filters#comments which says "Any rule that starts with an exclamation mark is considered a comment. " we should be supporting `!foo`. 
     11Based on what I read at https://adblockplus.org/en/filters#comments which says "Any rule that starts with an exclamation mark is considered a comment. " we should be supporting `!foo` mixed in with the special comments.