Changes between Version 8 and Version 12 of Ticket #6923


Ignore:
Timestamp:
09/11/2018 07:47:08 PM (14 months ago)
Author:
sebastian
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #6923

    • Property Status changed from reviewing to closed
    • Property Resolution changed from to fixed
  • Ticket #6923 – Description

    v8 v12  
    88=== What to change === 
    99Stop parsing special/metadata comments in `lib/synchronizer.js` as soon as we hit the first line after the header that isn't a non-empty comment. 
     10 
     11=== Hints for testers === 
     12When a filter list is downloaded, special comments should be processed if (and only if) they occur after the header and before any line that isn't a non-empty comment. 
     13 
     14Following filter list for example should show up under the name "foo" and with `https://example.com` as homepage in the settings: 
     15 
     16{{{ 
     17[Adblock Plus 2.0] 
     18! not a key: bla 
     19! Title: foo 
     20! Just a comment 
     21! Homepage: https://example.com 
     22||example.com^ 
     23}}} 
     24 
     25Following examples don't include any metadata to be processed (i.e. the the settings should show the URL instead of a name): 
     26 
     27{{{ 
     28[Adblock Plus 2.0] 
     29! 
     30! Title: foo 
     31}}} 
     32 
     33{{{ 
     34[Adblock Plus 2.0] 
     35||example.com^ 
     36! Title: foo 
     37}}} 
     38 
     39You might also want to try different combinations and/or other [https://adblockplus.org/filters#special-comments special comments].