Changes between Version 13 and Version 14 of Ticket #6923


Ignore:
Timestamp:
09/15/2018 04:12:53 PM (13 months ago)
Author:
sebastian
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #6923

    • Property Status changed from closed to reopened
    • Property Resolution changed from fixed to
  • Ticket #6923 – Description

    v13 v14  
    77 
    88=== What to change === 
    9 Stop parsing special/metadata comments in `lib/synchronizer.js` as soon as we hit the first line after the header that isn't a non-empty comment. 
     9Stop parsing special/metadata comments in `lib/synchronizer.js` as soon as we hit the first line after the header that isn't a comment with a colon. 
    1010 
    1111=== Hints for testers === 
    12 When a filter list is downloaded, special comments should be processed if (and only if) they occur after the header and before any line that isn't a non-empty comment. 
     12When a filter list is downloaded, special comments should be processed if (and only if) given after the header and before any line that isn't a comment with a colon. 
    1313 
    1414Following filter list for example should show up under the name "foo" and with `https://example.com` as homepage in the settings: 
     
    1717[Adblock Plus 2.0] 
    1818! not a key: bla 
    19 ! Title: foo 
    20 ! Just a comment 
     19! Title  : foo 
    2120! Homepage: https://example.com 
    2221||example.com^ 
  • Ticket #6923 – Review URL(s)

    v13 v14  
    11https://codereview.adblockplus.org/29873570 
     2https://codereview.adblockplus.org/29879940