Opened 8 months ago

#6925 new change

Remove selector-no-qualifying-type stylelint rule

Reported by: greiner Assignee:
Priority: Unknown Milestone:
Module: Automation Keywords:
Cc: ire, juliandoucette, agiammarchi, saroyanm Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description

Background

stylelint-config-eyeo includes the rule

"selector-no-qualifying-type": [true, {"ignore": ["attribute"]}]

However, this rule causes various issues throughout adblockplusui and likely also other eyeo repositories which is why it may not be appropriate for inclusion in stylelint-config-eyeo.

Also note that we did discuss adapting our code to this rule but had to settle on not doing so since it would require further changes beyond those and may introduce regressions (see discussion).

What to change

Remove "selector-no-qualifying-type" rule from stylelint-config-eyeo.

Change History (0)

Note: See TracTickets for help on using tickets.