Opened 15 months ago

Closed 14 months ago

Last modified 13 months ago

#6935 closed defect (fixed)

IOBigToggle not rendered

Reported by: agiammarchi Assignee:
Priority: P1 Milestone:
Module: User-Interface Keywords:
Cc: Blocked By:
Blocking: #6892 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://gitlab.com/eyeo/adblockplus/abpui/adblockplusui/merge_requests/107

Description

To simplify IOElement lifecycle I've made some change to the HyperHTMLElement library that did not consider that IOSteps need to invoke created() N times and also inheritance might compromise initialization of each component.

Since, after investigation, I've discovered there was no issuw with older Firefox, I've updated the library to render automatically on creation if no created method is available (already tested too).

Change History (8)

comment:1 Changed 15 months ago by agiammarchi

  • Resolution set to fixed
  • Status changed from new to closed

comment:2 Changed 15 months ago by greiner

  • Blocking 6892 added
  • Priority changed from Unknown to P1
  • Ready set
  • Review URL(s) modified (diff)

comment:3 Changed 14 months ago by abpbot

A commit referencing this issue has landed:
Issue 6935 - Update HyperHTMLELement to render IOBigToggle too

comment:4 Changed 14 months ago by agiammarchi

  • Resolution fixed deleted
  • Status changed from closed to reopened

comment:5 Changed 14 months ago by agiammarchi

Turns out, the version I've updated wasn't good enough to fix the issue in every browser.

comment:6 Changed 14 months ago by agiammarchi

I'll close this as soon as I can double check the big toggle is visible in all our target browsers.

comment:7 Changed 14 months ago by agiammarchi

  • Resolution set to fixed
  • Status changed from reopened to closed

comment:8 Changed 13 months ago by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Done. The big toggle is working as expected in all our target browsers.

ABP 3.3.2.2175
Firefox 62 / 51 / Windows 10
Chrome 69 / 49 / Windows 10
Opera 56 / 36 / Windows 10

Note: See TracTickets for help on using tickets.