Opened 8 months ago

Last modified 10 days ago

#6936 new change

Update adblockplusui dependency to TBD (release-2018-5)

Reported by: greiner Assignee:
Priority: Unknown Milestone:
Module: Platform Keywords:
Cc: wspee, sebastian Blocked By: #5960, #6323, #6324, #6328, #6397, #6641, #6765, #6875, #6880, #6951, #6952, #6968, #6973, #6984, #6995, #7005, #7022, #7023, #7066, #7091, #7106, #7109, #7110, #7118, #7127, #7134, #7139, #7140, #7144, #7148, #7227, #7228, #7229, #7231, #7234, #7239, #7247, #7251, #7264, #7288, #7292, #7300, #7304, #7306, #7327
Blocking: Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description (last modified by greiner)

Background

This imports the following changes:

Ticket Status Resolution Summary Component Owner
#5960 closed fixed Fix incorrect source strings in "mobile options" project User-Interface greiner
#6323 closed fixed Move composer.html related files to adblockplusui User-Interface greiner
#6324 closed fixed Move messageResponder.js to lib directory User-Interface greiner
#6328 closed fixed Move all icons into skin/icons directory in adblockplusui User-Interface greiner
#6397 closed fixed Implement language dropdown User-Interface agiammarchi
#6641 closed fixed Copyright year in about dialog is out of date User-Interface greiner
#6765 closed rejected No COPYING file in the root directory Platform
#6875 closed fixed Implement IOFilterList with infinite scroll User-Interface agiammarchi
#6880 closed fixed Make DevTools panel translatable User-Interface greiner
#6951 closed fixed Nightly builds don't include bundles User-Interface wspee
#6952 closed fixed Build Nightlies to feature branches User-Interface wspee
#6968 closed fixed Remove unused translatable strings from popup.json User-Interface greiner
#6973 closed fixed Open rewritten URLs in resources DevTools panel User-Interface greiner
#6984 closed fixed Remove duplicate gear icons from adblockplusui User-Interface greiner
#6995 closed fixed Add chrome builds to ABP UI Nightlies User-Interface wspee
#7005 closed fixed ABP UI Nightlies are missing peer dependencies User-Interface wspee
#7022 closed fixed Automatically use latest matching branch of adblockpluschrome for nightlies User-Interface wspee
#7023 closed fixed Add warning to issue reporter for screen readers User-Interface greiner
#7066 closed fixed Homepage meta data is ignored from some subscriptions User-Interface greiner
#7091 reviewing Create font generation tool User-Interface saroyanm
#7106 closed fixed Add configuration options and extension details to issue reports User-Interface greiner
#7109 closed fixed Add default characters to the font generations process User-Interface saroyanm
#7110 closed fixed Only show bubble UI notification for pages that match URL filters User-Interface greiner
#7118 closed fixed Remove duplicated trash icon User-Interface agiammarchi
#7127 closed fixed Use npm script instead of build.py checktranslations command User-Interface greiner
#7134 closed fixed Firefox `event.layerX` coordinates off by `element.offsetLeft` User-Interface agiammarchi
#7139 closed fixed Chrome nightlies unuseable due to non numerical version number User-Interface wspee
#7140 closed fixed CI Pipeline succeeds despite linting errors User-Interface agiammarchi
#7144 closed fixed Fix issue reporter mock User-Interface greiner
#7148 closed fixed Change extension description used in manifest User-Interface wspee
#7227 closed fixed Custom filter list toggle might prematurely re-render User-Interface agiammarchi
#7228 closed fixed Contextual buttons remain after deleting selected items User-Interface agiammarchi
#7229 closed fixed Whitelisted websites list not alphabetically sorted User-Interface greiner
#7231 closed fixed Cumulative fixes for io-filter-search User-Interface agiammarchi
#7234 closed fixed Cumulative fixes for io-filter-list User-Interface agiammarchi
#7239 closed fixed Make links on first-run page more distinct from regular text User-Interface greiner
#7247 closed fixed Improve filter table search visualization User-Interface agiammarchi
#7251 closed fixed Remove currently useless table toggle User-Interface agiammarchi
#7264 closed fixed Update filter table warning message User-Interface agiammarchi
#7288 closed fixed Custom filter table uses removed function User-Interface greiner
#7292 closed fixed Cumulative fixes for io-filter-table User-Interface agiammarchi
#7300 closed fixed Add language dialog mislocated in RTL environment User-Interface agiammarchi
#7304 closed fixed io-filter-list editing long filters is bad UX User-Interface agiammarchi
#7306 closed fixed Line number in filter error refer to wrong filter User-Interface greiner
#7327 closed fixed Update options.showOptions calls to use Promises User-Interface kzar


It also imports the following Noissue changes:

  • NoIssue - add clipboard utility for copy/paste operations
  • Noissue - Added nightlies to README.md
  • Noissue - Added skin directory to linting
  • Noissue - Added translations for release-2018-5 branch
  • NoIssue - Bring in release-2018-5 latest dom.js updates
  • NoIssue - Close tab on Issue Reporter sent
  • NoIssue - expose info about slow filters
  • Noissue - Fixed broken trash icon in Firefox mobile
  • Noissue - Fixed Filter Lists order in the advanced tab
  • Noissue - Fixed font-tools linting error
  • Noissue - Fixed regression: Incorrect references to message responder in tests and README
  • Noissue - Fixed release branch regex to include bug fix releases (i.e. release-YYYY-N.N)
  • Noissue - Fixed: Build scripts were ignored by linter
  • Noissue - Fixed: Hardcoded copyright year placeholder value
  • Noissue - Fixed: Messaging port mock events sent to all listeners with same name
  • Noissue - Fixed: Removed extra character after custom filter table error message
  • NoIssue - Implement IOCheckbox
  • Noissue - Imported translations from Crowdin
  • NoIssue - Improve IOFilterSearch
  • Noissue - Include commit hash of adblockpluschrome in nightly console output
  • NoIssue - package.json dependencies update
  • Noissue - Removed unused background images
  • NoIssue - Simplify extension build
  • NoIssue - temporarily disabled json linter
  • NoIssue - update CI NodeJS version to 10 LTS
  • NoIssue - update HyperHTMLElement to latest
  • NoIssue - Update npm dependencies
  • NoIssue - use lowercase instead of isCamelCase
  • reverted json change
  • Use the io-filter-table instead of the textarea

What to change

  • Change adblockplusui dependency to TBD
  • Apply necessary changes (see release-2018-5)

Hints for testers

Everything should be implemented according to the spec.
See also hints for testers section in the individual tickets.

Missing information

The scope of this UI release hasn't been decided yet.

Change History (63)

comment:1 Changed 8 months ago by greiner

  • Description modified (diff)

comment:2 Changed 8 months ago by greiner

  • Description modified (diff)

comment:3 Changed 8 months ago by greiner

  • Blocked By 6397 added

comment:4 Changed 8 months ago by greiner

  • Blocked By 5960 added

comment:5 Changed 8 months ago by greiner

  • Blocked By 6880 added

comment:6 Changed 8 months ago by greiner

  • Cc wspee added

comment:7 Changed 8 months ago by greiner

  • Blocked By 6641 added

comment:8 Changed 7 months ago by greiner

  • Blocked By 6960 added

comment:9 Changed 7 months ago by greiner

  • Blocked By 6960 removed

comment:10 Changed 7 months ago by greiner

  • Blocked By 6968 added

comment:11 Changed 7 months ago by greiner

  • Blocked By 6973 added

comment:12 Changed 7 months ago by greiner

  • Blocked By 6323 added

comment:13 Changed 7 months ago by greiner

  • Description modified (diff)

comment:14 Changed 7 months ago by greiner

  • Blocked By 6984 added

comment:15 Changed 7 months ago by greiner

  • Blocked By 7023 added

comment:16 Changed 7 months ago by greiner

  • Blocked By 6765 added

comment:17 Changed 7 months ago by greiner

  • Blocked By 6328 added

comment:18 Changed 6 months ago by greiner

  • Blocked By 7066 added

comment:19 Changed 6 months ago by greiner

  • Blocked By 7106 added

comment:20 Changed 6 months ago by greiner

  • Blocked By 7110 added

comment:21 Changed 6 months ago by greiner

  • Blocked By 7093 added

comment:22 Changed 6 months ago by greiner

  • Blocked By 7093 removed

comment:23 Changed 5 months ago by greiner

  • Blocked By 7110 removed

comment:24 Changed 5 months ago by greiner

  • Blocked By 6324 added

comment:25 Changed 5 months ago by greiner

  • Blocked By 6875 added

comment:26 Changed 5 months ago by greiner

  • Blocked By 6951 added

comment:27 Changed 5 months ago by greiner

  • Blocked By 6952 added

comment:28 Changed 5 months ago by greiner

  • Blocked By 6995 added

comment:29 Changed 5 months ago by greiner

  • Blocked By 7005 added

comment:30 Changed 5 months ago by greiner

  • Blocked By 7022 added

comment:31 Changed 5 months ago by greiner

  • Blocked By 7091 added

comment:32 Changed 5 months ago by greiner

  • Blocked By 7109 added

comment:33 Changed 5 months ago by greiner

  • Blocked By 7118 added

comment:34 Changed 5 months ago by greiner

  • Blocked By 7134 added

comment:35 Changed 5 months ago by greiner

  • Description modified (diff)

Added Noissue changes to ticket description.

comment:36 Changed 5 months ago by greiner

  • Blocked By 7110 added

comment:37 Changed 5 months ago by greiner

  • Description modified (diff)

Filled in empty sections in ticket description.

comment:38 Changed 5 months ago by greiner

  • Blocked By 7127 added

comment:39 Changed 5 months ago by greiner

  • Blocked By 7144 added

comment:40 Changed 3 months ago by greiner

  • Description modified (diff)

Fixed typo in ticket description

comment:41 Changed 7 weeks ago by greiner

  • Blocked By 7327 added

comment:42 Changed 6 weeks ago by greiner

  • Blocked By 7140 added

comment:43 Changed 6 weeks ago by greiner

  • Blocked By 7139 added

comment:44 Changed 6 weeks ago by greiner

  • Blocked By 7148 added

comment:45 Changed 6 weeks ago by greiner

  • Blocked By 7229 added

comment:46 Changed 6 weeks ago by greiner

  • Blocked By 7231 added

comment:47 Changed 6 weeks ago by greiner

  • Blocked By 7234 added

comment:48 Changed 6 weeks ago by greiner

  • Blocked By 7239 added

comment:49 Changed 6 weeks ago by greiner

  • Blocked By 7247 added

comment:50 Changed 6 weeks ago by greiner

  • Blocked By 7251 added

comment:51 Changed 6 weeks ago by greiner

  • Blocked By 7264 added

comment:52 Changed 6 weeks ago by greiner

  • Blocked By 7288 added

comment:53 Changed 6 weeks ago by greiner

  • Blocked By 7292 added

comment:54 Changed 6 weeks ago by greiner

  • Blocked By 7300 added

comment:55 Changed 6 weeks ago by greiner

  • Blocked By 7304 added

comment:56 Changed 6 weeks ago by greiner

  • Blocked By 7306 added

comment:57 Changed 6 weeks ago by greiner

  • Blocked By 7228 added

comment:58 Changed 6 weeks ago by greiner

  • Blocked By 7227 added

comment:59 Changed 6 weeks ago by greiner

  • Description modified (diff)

Added new Noissue changes to ticket description.

comment:60 Changed 3 weeks ago by sebastian

  • Cc sebastian added

It seems #7345 also been merged into the 2018-5 release branch, but isn't mentioned in te issue description here, or do I miss something? Any other discrepancies?

comment:61 Changed 3 weeks ago by greiner

Since Trac isn't being actively kept up-to-date by us, not all tickets have been marked as blocking the dependency update yet but I'd do so as soon as work starts for the next major extension release so that the dependency update can be made ready.

In the meantime, you can check out the GitLab board for this UI release to find out exactly which issues will be part of the dependency update. Alternatively, you'll find all changes that are missing from this ticket in the branch's commit history by looking at the ones created since the last update to this ticket was made.

Hope that helps.

comment:62 Changed 2 weeks ago by jsonesen

  • Blocking 7308 added

comment:63 Changed 10 days ago by greiner

  • Blocking 7308 removed
Note: See TracTickets for help on using tickets.