Changes between Initial Version and Version 1 of Ticket #6936, comment 94


Ignore:
Timestamp:
05/23/2019 06:07:56 PM (15 months ago)
Author:
kzar
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #6936, comment 94

    initial v1  
    1 For reference, it seems that the noissue commit Use the [https://gitlab.com/eyeo/adblockplus/abpui/adblockplusui/commit/d411b7f52643aaa566dc8bca7f1349be71d22867#7030d0b2f71b999ff89a343de08c414af32fc93a_62_62 io-filter-table instead of the textarea] accidentally(?) included a change to package.json which caused `eslint` to run in production as well. That in turn is [https://gitlab.com/eyeo/adblockplus/adblockpluschrome/-/jobs/217042917 causing our CI to fail] since the `eslint` command is not necessarily available. It looks like we'll need to revert that change to package.json and update the adblockplusui dependency again. 
     1For reference, it seems that the noissue commit [https://gitlab.com/eyeo/adblockplus/abpui/adblockplusui/commit/d411b7f52643aaa566dc8bca7f1349be71d22867#7030d0b2f71b999ff89a343de08c414af32fc93a_62_62 Use the io-filter-table instead of the textarea] accidentally(?) included a change to package.json which caused `eslint` to run in production as well. That in turn is [https://gitlab.com/eyeo/adblockplus/adblockpluschrome/-/jobs/217042917 causing our CI to fail] since the `eslint` command is not necessarily available. It looks like we'll need to revert that change to package.json and update the adblockplusui dependency again.