Update adblockplusui dependency to 085509a03c94 (release-2018-5)

[greiner]

Background

This imports the following changes:

Ticket	Status	Resolution	Summary	Component	Owner
#5960	closed	fixed	Fix incorrect source strings in "mobile options" project	User-Interface	greiner
#6323	closed	fixed	Move composer.html related files to adblockplusui	User-Interface	greiner
#6324	closed	fixed	Move messageResponder.js to lib directory	User-Interface	greiner
#6328	closed	fixed	Move all icons into skin/icons directory in adblockplusui	User-Interface	greiner
#6397	closed	fixed	Implement language dropdown	User-Interface	agiammarchi
#6641	closed	fixed	Copyright year in about dialog is out of date	User-Interface	greiner
#6765	closed	rejected	No COPYING file in the root directory	Platform
#6875	closed	fixed	Implement IOFilterList with infinite scroll	User-Interface	agiammarchi
#6880	closed	fixed	Make DevTools panel translatable	User-Interface	greiner
#6951	closed	fixed	Nightly builds don't include bundles	User-Interface	wspee
#6952	closed	fixed	Build Nightlies to feature branches	User-Interface	wspee
#6968	closed	fixed	Remove unused translatable strings from popup.json	User-Interface	greiner
#6973	closed	fixed	Open rewritten URLs in resources DevTools panel	User-Interface	greiner
#6984	closed	fixed	Remove duplicate gear icons from adblockplusui	User-Interface	greiner
#6995	closed	fixed	Add chrome builds to ABP UI Nightlies	User-Interface	wspee
#7005	closed	fixed	ABP UI Nightlies are missing peer dependencies	User-Interface	wspee
#7022	closed	fixed	Automatically use latest matching branch of adblockpluschrome for nightlies	User-Interface	wspee
#7023	closed	fixed	Add warning to issue reporter for screen readers	User-Interface	greiner
#7066	closed	fixed	Homepage meta data is ignored from some subscriptions	User-Interface	greiner
#7091	closed	fixed	Create font generation tool	User-Interface	saroyanm
#7109	closed	fixed	Add default characters to the font generations process	User-Interface	saroyanm
#7110	closed	fixed	Only show bubble UI notification for pages that match URL filters	User-Interface	greiner
#7118	closed	fixed	Remove duplicated trash icon	User-Interface	agiammarchi
#7134	closed	fixed	Firefox `event.layerX` coordinates off by `element.offsetLeft`	User-Interface	agiammarchi
#7139	closed	fixed	Chrome nightlies unuseable due to non numerical version number	User-Interface	wspee
#7140	closed	fixed	CI Pipeline succeeds despite linting errors	User-Interface	agiammarchi
#7144	closed	fixed	Fix issue reporter mock	User-Interface	greiner
#7148	closed	fixed	Change extension description used in manifest	User-Interface	wspee
#7175	closed	fixed	Issue reporter is broken on Edge	User-Interface	agiammarchi
#7229	closed	fixed	Whitelisted websites list not alphabetically sorted	User-Interface	greiner
#7231	closed	fixed	Cumulative fixes for io-filter-search	User-Interface	agiammarchi
#7234	closed	fixed	Cumulative fixes for io-filter-list	User-Interface	agiammarchi
#7239	closed	fixed	Make links on first-run page more distinct from regular text	User-Interface	greiner
#7247	closed	fixed	Improve filter table search visualization	User-Interface	agiammarchi
#7251	closed	fixed	Remove currently useless table toggle	User-Interface	agiammarchi
#7264	closed	fixed	Update filter table warning message	User-Interface	agiammarchi
#7288	closed	fixed	Custom filter table uses removed function	User-Interface	greiner
#7292	closed	fixed	Cumulative fixes for io-filter-table	User-Interface	agiammarchi
#7300	closed	fixed	Add language dialog mislocated in RTL environment	User-Interface	agiammarchi
#7304	closed	fixed	io-filter-list editing long filters is bad UX	User-Interface	agiammarchi
#7306	closed	fixed	Line number in filter error refer to wrong filter	User-Interface	greiner
#7327	closed	fixed	Update options.showOptions calls to use Promises	User-Interface	kzar
#7345	closed	fixed	Use promises for extension API calls in UI (release-2018-5)	User-Interface	greiner
#7357	closed	fixed	Disable filter table rich text paste	User-Interface	agiammarchi
#7439	closed	fixed	Custom filter table: trigger an error on wrong header	User-Interface	agiammarchi
#7472	closed	fixed	Re-set CSS --width on window resize	User-Interface	agiammarchi

It also imports the following changes that are tracked only on GitLab:

• ​ui#281 remove contextual buttons after deleting items
• ​ui#303 do not force render the toggle
• ​ui#380 Adapt code to work with removed third-party parameter in filter matcher
• ​ui#412 Fixed: Weibo link not shown in Help tab
• ​ui#415 Unable to add filter lists via abp:subscribe if the options page is closed
• ​ui#416 Closing language dropdown issues
• ​ui#419 Custom filter table: Disabled filter is re-enabled after refresh in the UI
• ​ui#425 Fixed regression: ESLint missing when building for production

It also imports the following Noissue changes:

• ​Noissue - Fixed: New imports not exposed by mock modules
• ​NoIssue - Remove G+ icon&link
• ​Noissue - Added documentation about test environment
• ​Noissue - Fixed: Rebase led to wrong imports in message responder
• ​Noissue - Imported translations from Crowdin
• ​Noissue - Imported translations from Crowdin
• ​Noissue - Added translations for release-2018-5 branch
• ​Noissue - Fixed: Messaging port mock events sent to all listeners with same name
• ​Noissue - Fixed Filter Lists order in the advanced tab
• ​reverted json change
• ​Noissue - Fixed broken trash icon in Firefox mobile
• ​NoIssue - update HyperHTMLElement to latest
• ​Noissue - Fixed: Removed extra character after custom filter table error message
• ​Use the io-filter-table instead of the textarea
• ​Noissue - Fixed: Hardcoded copyright year placeholder value
• ​Noissue - Imported translations from Crowdin
• ​NoIssue - Close tab on Issue Reporter sent
• ​NoIssue - Update npm dependencies
• ​Noissue - Fixed font-tools linting error
• ​NoIssue - Bring in release-2018-5 latest dom.js updates
• ​Noissue - Fixed regression: DevTools panel broken in mock environment
• ​NoIssue - Implement IOCheckbox
• ​Noissue - Fixed regression: Incorrect references to message responder in tests and README
• ​NoIssue - use lowercase instead of isCamelCase
• ​Noissue - Removed unused background images
• ​NoIssue - Simplify extension build
• ​NoIssue - Improve IOFilterSearch
• ​NoIssue - expose info about slow filters
• ​NoIssue - add clipboard utility for copy/paste operations
• ​Noissue - Also build nightlies for compat branches
• ​Noissue - Backported npm test script from 3134c7ea108ddf1ac0848acac0cc5ba6575831d6
• ​Noissue - Backported devDependencies cleanup from 7f089882dbe6348b15b90047770efbbe577df658
• ​Noissue - Backported bash syntax error fix for in $ bundle.test from 7f089882dbe6348b15b90047770efbbe577df658
• ​NoIssue - update CI NodeJS version to 10 LTS
• ​NoIssue - temporarily disabled json linter
• ​Noissue - Include commit hash of adblockpluschrome in nightly console output
• ​Noissue - Added nightlies to README.md
• ​Noissue - Added skin directory to linting
• ​Noissue - Fixed release branch regex to include bug fix releases (i.e. release-YYYY-N.N)
• ​Noissue - Fixed: Build scripts were ignored by linter
• ​NoIssue - package.json dependencies update

What to change

• Change adblockplusui dependency to hg:e1eb6e993ab8 git:8774527.
• Update the following files:
  • lib/options.js: Return Promise from showOptions()
  • .eslintignore: Remove jquery-ui/js/*
  • metadata.chrome:
    • Add adblockplusui/locale/*/devtools-panel.json = * for translations
    • Update reference from adblockplusui/messageResponder.js to adblockplusui/lib/messageResponder.js
    • Update mappings:

Before	After
(none)	composer.html = adblockplusui/composer.html
(none)	composer.js = adblockplusui/composer.js
(none)	skin/composer.css = adblockplusui/skin/composer.css
(none)	skin/icons/alert.svg = adblockplusui/skin/icons/alert.svg
(none)	skin/icons/copy.svg = adblockplusui/skin/icons/copy.svg
(none)	skin/icons/error.svg = adblockplusui/skin/icons/error.svg
icons/detailed/abp-128.png = adblockplusui/skin/abp-128.png	icons/detailed/abp-128.png = adblockplusui/skin/icons/abp-128.png
skin/abb-logo.png = adblockplusui/skin/abb-logo.png	(none)
skin/abp-logo.svg = adblockplusui/skin/abp-logo.svg	skin/icons/abp-logo.svg = adblockplusui/skin/icons/abp-logo.svg
skin/icons/options.svg = adblockplusui/skin/icons/options.svg	(none)
skin/social/facebook.svg = adblockplusui/skin/social/facebook.svg	skin/icons/facebook.svg = adblockplusui/skin/icons/facebook.svg
skin/social/googleplus.svg = adblockplusui/skin/social/googleplus.svg	skin/icons/googleplus.svg = adblockplusui/skin/icons/googleplus.svg
skin/social/twitter.svg = adblockplusui/skin/social/twitter.svg	skin/icons/twitter.svg = adblockplusui/skin/icons/twitter.svg
skin/updates/base-graphic.svg = adblockplusui/skin/updates/base-graphic.svg	skin/icons/updates/base-graphic.svg = adblockplusui/skin/icons/updates/base-graphic.svg
skin/updates/icon-mobile.svg = adblockplusui/skin/updates/icon-mobile.svg	skin/icons/updates/mobile.svg = adblockplusui/skin/icons/updates/mobile.svg
skin/updates/icon-rocket.svg = adblockplusui/skin/updates/icon-rocket.svg	skin/icons/updates/rocket.svg = adblockplusui/skin/icons/updates/rocket.svg
skin/updates/icon-thumbs-up.svg = adblockplusui/skin/updates/icon-thumbs-up.svg	skin/icons/updates/thumbs-up.svg = adblockplusui/skin/icons/updates/thumbs-up.svg

• metadata.gecko:
  • Update mappings:

Before	After
skin/mobile/checkmark.svg = adblockplusui/skin/mobile/checkmark.svg	skin/icons/mobile/checkmark.svg = adblockplusui/skin/icons/mobile/checkmark.svg
skin/mobile/toggle.svg = adblockplusui/skin/mobile/toggle.svg	skin/icons/mobile/toggle.svg = adblockplusui/skin/icons/mobile/toggle.svg
skin/mobile/trash.svg = adblockplusui/skin/mobile/trash.svg	skin/icons/mobile/trash.svg = adblockplusui/skin/icons/mobile/trash.svg

• Remove the following files:
  • icons/detailed/abp-32.png
  • jquery-ui/
  • composer.html
  • composer.js

For reference, see ​changes in UI fork of adblockpluschrome.

Hints for testers

Everything should be implemented ​according to the spec.

A few of the referenced issues have their own testing instructions:

• 6328 - Move all icons into skin/icons directory in adblockplusui
• ​7091 - Create font generation tool
• 7327 - Update options.showOptions calls to use Promises
• 7345 - Use promises for extension API calls in UI (release-2018-5)
• ​ui#380 - Adapt code to work with removed third-party parameter in filter matcher
• ​ui#415 - Unable to add filter lists via abp:subscribe if the options page is closed
• ​ui#419 - Custom filter table: Disabled filter is re-enabled after refresh in the UI

Furthermore, the following hints apply to the various Noissue changes:

• Button at the end of the issue reporter should close the issue reporter tab
• Copyright year should correspond to current year in "About Adblock Plus" dialog in desktop settings page
• Custom elements should continue to work
  • Enable toggle in bubble UI
  • Screenshot tool in issue reporter
  • Step buttons in header of issue reporter
  • Tooltips in desktop settings page
• Filter lists in Advanced tab in desktop settings page should be showing corresponding download status
• Filter lists in Advanced tab in desktop settings page should be sorted alphabetically
• In mock environment:
  • Data should be initialized in DevTools panel
• Trash icon should be shown in mobile settings page

[greiner]

Added Noissue changes to ticket description.

[greiner]

Filled in empty sections in ticket description.

[greiner]

Fixed typo in ticket description

[greiner]

Added new Noissue changes to ticket description.

[sebastian]

It seems #7345 also been ​merged into the 2018-5 release branch, but isn't mentioned in te issue description here, or do I miss something? Any other discrepancies?

[greiner]

Since Trac isn't being actively kept up-to-date by us, not all tickets have been marked as blocking the dependency update yet but I'd do so as soon as work starts for the next major extension release so that the dependency update can be made ready.

In the meantime, you can check out ​the GitLab board for this UI release to find out exactly which issues will be part of the dependency update. Alternatively, you'll find all changes that are missing from this ticket ​in the branch's commit history by looking at the ones created since the last update to this ticket was made.

Hope that helps.

[greiner]

Added GitLab-only issues.

[greiner]

Updated missing information section.

[greiner]

Added specific instructions to what to change section.

[greiner]

Added one more GitLab issue that turned out to be necessary for compatibility with adblockpluscore.

[greiner]

Added Noissue change that fixes the latest rebase.

[greiner]

Added commit hashes to ticket description.

[kzar]

I noticed the following blocking issues which didn't correspond to included commits:

5960, 6397, 6765, 6880, 6951, 6952, 6995, 7005, 7022, 7139, 7140, 7227, 7228

If you'd like to add them back as blocking go ahead, but please make sure they're excluded from the table which lists included changes.

[kzar]

For the testing hints you mention "the spec", but please could you link to it as well? Also, please could you add testing hints (where relevant) for the code touched by Noissue commits?

[greiner]

I noticed the following blocking issues which didn't correspond to included commits:

All of the mentioned tickets (except for the last two which refer to the GitLab issue instead of the Trac ticket) have comments at the end that refer to the commit that got pushed to Mercurial yesterday. Therefore I'm wondering why they wouldn't be included?!

For the testing hints you mention "the spec", but please could you link to it as well? Also, please could you add testing hints (where relevant) for the code touched by Noissue commits?

Sure, I've added a link to the spec repository.

[kzar]

Heads up, this one will require a lot of testing when it lands!

[kzar]

Therefore I'm wondering why they wouldn't be included?!

Sorry, shows me for using the GitHub UI instead of the command line... git log 17697d3...bbfb52b --oneline quickly shows me the mising commits. I wish I did that sooner, since git log 17697d3...bbfb52b --oneline | grep -v '[0-9] -' was a lot quicker way of coming up with a list of included Noissue commits as well... Fixed now.

[greiner]

Added hints for testers for Noissue changes.

[kzar]

Replying to greiner:

Added hints for testers for Noissue changes.

Thanks for that.

Please could you go through the included issues and check that they do have suitable testing hints? I went through the first 20 or so issues and didn't find any testing hints at all (including checking the linked GitLab issues). Seems wrong since this issue tells the testers to check out the testing hints in the included issues.

[kzar]

As discussed in IRC I've linked to the few issues which do have testing instructions.

[abpbot]

A commit referencing this issue has landed:
​Issue 6936 - Update adblockplusui dependency to bbfb52b

[kzar]

For reference, it seems that the noissue commit ​Use the io-filter-table instead of the textarea accidentally(?) included a change to package.json which caused eslint to run in production as well. That in turn is ​causing our CI to fail since the eslint command is not necessarily available. It looks like we'll need to revert that change to package.json and update the adblockplusui dependency again.

[greiner]

For reference, there's ​this particular comment that led to this change. We can either revert the change or stop running the linter when creating bundles altogether.

[abpbot]

A commit referencing this issue has landed:
​Issue 6936 - Update adblockplusui dependency to 8774527

[abpbot]

A commit referencing this issue has landed:
​Issue 6936 - Adjust Weibo and Google Plus icon mappings