Changes between Version 2 and Version 4 of Ticket #6939


Ignore:
Timestamp:
10/05/2018 12:31:51 PM (13 months ago)
Author:
mjethani
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #6939

    • Property Priority changed from Unknown to P3
    • Property Ready set
  • Ticket #6939 – Description

    v2 v4  
    2222 1.  Add an additional check for TLDs in `ContentFilter.fromText`; this additional check would reject any filters containing a TLD, like the one in this issue (unless it's `localhost`, see #6931); unfortunately this would also likely slow down the loading of the filters. 
    2323 2.  Don't check for TLDs in `ContentFilter.fromText`, but instead, do one of the following: (1) do the check at the time of looking up the filters in `Snippets.getFiltersForDomain`, etc.; (2) check for well-known [https://publicsuffix.org/ public suffixes] instead, also in `Snippets.getFiltersForDomain`, etc; (3) don't check anything anywhere. 
     24 
     25Also see ticket:6773#comment:13