Opened 2 years ago

Last modified 11 months ago

#6939 closed defect

No-TLD restriction for content filters does not work if there's at least one non-TLD — at Initial Version

Reported by: mjethani Assignee:
Priority: P3 Milestone:
Module: Core Keywords: closed-in-favor-of-gitlab
Cc: hfiguiere, sebastian Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description

Environment

ABP 3.3.1 on Chrome, macOS 10.12.6

How to reproduce

  1. Add the filter com,example.com#$#log 'Hello, .com!'
  2. Load example.com in a new tab
  3. Open the DevTools console for the tab
  4. Load eyeo.com in a new tab
  5. Open the DevTools console for the tab

Observed behaviour

In both steps 3 and 5, you see "Hello, .com!" printed to the console

Expected behaviour

Since com isn't a valid domain as per the restrictions (which may be changed as part of resolving this issue, by the way), it should consistently not be allowed in element hiding emulation and snippet filters. At the very least the filter should not be applied on unrelated domains like eyeo.com. Even better, the filter should be considered invalid.

Change History (0)

Note: See TracTickets for help on using tickets.