Opened 9 months ago

Closed 9 months ago

Last modified 8 months ago

#6949 closed change (fixed)

Update adblockpluscore to c99ba575161f

Reported by: hfiguiere Assignee: hfiguiere
Priority: P2 Milestone: Adblock-Plus-3.4-for-Chrome-Opera-Firefox
Module: Platform Keywords:
Cc: sebastian Blocked By: #6923, #6944
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29879654/

Description (last modified by sebastian)

Background

Update adblockpluscore dependency to get EasyList Portuguese into the default subscriptions, and to get the second part of the changes to the logic parsing the metadata from filter lists in.

What to change

Change dependencies for adblockplusore to c99ba575161f

This bring the following changes:

  • Issue #6944 - Added EasyList Portuguese
  • Issue #6923 (2nd part) - Simplify/Unify parsing of metadata in filter lists

Hint for testers

Change History (9)

comment:1 Changed 9 months ago by hfiguiere

  • Description modified (diff)
  • Owner set to hfiguiere

comment:2 Changed 9 months ago by hfiguiere

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed 9 months ago by sebastian

If possible, I'd like to get this patch in there as well. (So that we don't have to test this functionality twice.)

comment:4 Changed 9 months ago by hfiguiere

Fair enough. As long as we get it in.

comment:5 Changed 9 months ago by sebastian

  • Blocked By 6923, 6944 added
  • Description modified (diff)
  • Priority changed from Unknown to P2
  • Summary changed from Update adblockpluscore to hg:a735ad4e34e5 to Update adblockpluscore to ????

comment:6 Changed 9 months ago by sebastian

  • Description modified (diff)
  • Milestone set to Adblock-Plus-for-Chrome-Opera-Firefox-next
  • Ready set
  • Summary changed from Update adblockpluscore to ???? to Update adblockpluscore to c99ba575161f

comment:7 Changed 9 months ago by abpbot

A commit referencing this issue has landed:
Issue 6949 - Update adblockpluscore to hg:c99ba575161f git:ee3158d

comment:8 Changed 9 months ago by hfiguiere

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:9 Changed 8 months ago by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Done. Working as described.

ABP 3.3.2.2175
Firefox 62 / 51 / Windows 10
Chrome 69 / 49 / Windows 10
Opera 56 / 36 / Windows 10

Note: See TracTickets for help on using tickets.