Changes between Initial Version and Version 1 of Ticket #6956


Ignore:
Timestamp:
09/16/2018 04:18:24 PM (2 years ago)
Author:
mjethani
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #6956

    • Property Owner set to mjethani
  • Ticket #6956 – Description

    initial v1  
    11=== Background === 
    2 The extension generates the style sheet to be injected into each frame on its own, but this is the kind of logic that would ideally belong in core (similar to how code generation for snippets is done by core). Keeping this logic in the extension keeps us from doing certain optimizations. Mainly, after #6955, we should be able to maintain only one copy of the generic style sheet that is injected into every frame, thus saving a significant amount of memory in the extension. 
     2The extension generates the style sheet to be injected into each frame on its own, but this is the kind of logic that would ideally belong in core (similar to how [https://github.com/adblockplus/adblockpluscore/blob/ee3158dca717452047320cb69a80a59513997c71/lib/snippets.js#L181 code generation for snippets] is done by core). Keeping this logic in the extension keeps us from doing certain optimizations. Mainly, after #6955, we should be able to maintain only one copy of the generic style sheet that is injected into every frame, thus saving a significant amount of memory in the extension. 
    33 
    44=== What to change === 
    55Move the `createStyleSheet` utility function from adblockpluschrome's `lib/contentFiltering.js` into `lib/elemHide.js`. 
     6 
     7=== Integration notes === 
     8While this would be a non-breaking change, adblockpluschrome should be updated soon after to use the core version of `createStyleSheet`.